Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract @babel/highlight package from @babel/code-frame #7351

Merged
merged 1 commit into from Feb 9, 2018

Conversation

@suchipi
Copy link
Member

suchipi commented Feb 8, 2018

Q A
Fixed Issues? None
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR No
Any Dependency Changes? No
License MIT

This creates a new package called @babel/highlight which syntax highlights
JavaScript code for terminal output. This functionality was already
present in @babel/code-frame, but exposing it as a separate package lets
other projects leverage it. @babel/code-frame has been refactored
slightly so that it uses @babel/highlight to do its syntax highlighting.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 8, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6846/

},
"devDependencies": {
"chalk": "^2.0.0",

This comment has been minimized.

Copy link
@rajasekarm

rajasekarm Feb 8, 2018

Member

why we need chalk as a devdep here?

This comment has been minimized.

Copy link
@suchipi

suchipi Feb 8, 2018

Author Member

It's used in the tests.

Copy link
Member

xtuc left a comment

Yes good idea!

"name": "@babel/highlight",
"version": "7.0.0-beta.39",
"description": "Syntax highlight JavaScript strings for output in terminals.",
"author": "Sebastian McKenzie <sebmck@gmail.com>",

This comment has been minimized.

Copy link
@xtuc

xtuc Feb 8, 2018

Member

Shouldn't we change the author for new packages? Maybe @hzoo?

This comment has been minimized.

Copy link
@suchipi

suchipi Feb 8, 2018

Author Member

I wasn't sure what to put. Since he was listed as the author on code-frame, I assumed most of this code was written by Sebastian, so I kept it the same since I didn't add much.

This comment has been minimized.

Copy link
@xtuc

xtuc Feb 8, 2018

Member

Yes good point ok

This comment has been minimized.

Copy link
@hzoo

hzoo Feb 8, 2018

Member

I guess it could even be you @suchipi? It's a new package name, not really based on who wrote the most, although even for new packages we have been doing that which I'm not sure about either?

This comment has been minimized.

Copy link
@suchipi

suchipi Feb 8, 2018

Author Member

I'm fine changing it to my name 🤷‍♀️

This creates a new package called @babel/highlight which syntax highlights
JavaScript code for terminal output. This functionality was already
present in @babel/code-frame, but exposing it as a separate package lets
other projects leverage it. @babel/code-frame has been refactored
slightly so that it uses @babel/highlight to do its syntax highlighting.
@suchipi suchipi force-pushed the suchipi:babel_highlight branch from 4f2a8b2 to c9818f1 Feb 8, 2018
@hzoo
hzoo approved these changes Feb 8, 2018
@nicolo-ribaudo nicolo-ribaudo merged commit 534ee47 into babel:master Feb 9, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.38% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@suchipi

This comment has been minimized.

Copy link
Member Author

suchipi commented Feb 9, 2018

🎉 Thanks everyone!

@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants
You can’t perform that action at this time.