Extract @babel/highlight package from @babel/code-frame #7351
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6846/ |
| }, | ||
| "devDependencies": { | ||
| "chalk": "^2.0.0", |
There was a problem hiding this comment.
why we need chalk as a devdep here?
| "name": "@babel/highlight", | ||
| "version": "7.0.0-beta.39", | ||
| "description": "Syntax highlight JavaScript strings for output in terminals.", | ||
| "author": "Sebastian McKenzie <sebmck@gmail.com>", |
There was a problem hiding this comment.
Shouldn't we change the author for new packages? Maybe @hzoo?
There was a problem hiding this comment.
I wasn't sure what to put. Since he was listed as the author on code-frame, I assumed most of this code was written by Sebastian, so I kept it the same since I didn't add much.
There was a problem hiding this comment.
I guess it could even be you @suchipi? It's a new package name, not really based on who wrote the most, although even for new packages we have been doing that which I'm not sure about either?
There was a problem hiding this comment.
I'm fine changing it to my name 🤷♀️
This creates a new package called @babel/highlight which syntax highlights JavaScript code for terminal output. This functionality was already present in @babel/code-frame, but exposing it as a separate package lets other projects leverage it. @babel/code-frame has been refactored slightly so that it uses @babel/highlight to do its syntax highlighting.
suchipi
force-pushed
the
babel_highlight
branch
from
4f2a8b2
to
c9818f1
Compare
existentialism
added
the
PR: New Feature 🚀
|
🎉 Thanks everyone! |
lock
bot
added
the
outdated
This creates a new package called
@babel/highlightwhich syntax highlightsJavaScript code for terminal output. This functionality was already
present in
@babel/code-frame, but exposing it as a separate package letsother projects leverage it.
@babel/code-framehas been refactoredslightly so that it uses
@babel/highlightto do its syntax highlighting.