New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make env preset build-data scripts reproducible #8299
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8576/ |
@@ -60,8 +60,8 @@ | |||
"@babel/core": "7.0.0-beta.52", | |||
"@babel/helper-fixtures": "7.0.0-beta.52", | |||
"@babel/helper-plugin-test-runner": "7.0.0-beta.52", | |||
"caniuse-db": "1.0.30000851", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we maybe try some auto-updates for caniuse-db
& electron-to-chromium
? maybe just a greenkeeper-like integration (as fully automatic probably would have numerous flaws)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had good success with using https://renovatebot.com, which is very customizable and supports monorepos and is free for OSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we pinned the version of compat-table as well so this is good to me, unless we want to allow people to update before we do via peerDep or override if we are slow to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we'd need to get renovate to update dependencies and run the update script. I'm not sure if that'd be possible or not.
* master: remove .then from dynamic import parser exception message (babel#8355) update jest (major), babel-jest (major) (babel#8341) update prettier (babel#8339) bump flow (babel#8338) updates eslint, babel-eslint, eslint-plugin-flowtype, eslint-plugin-prettier (babel#8337) update changelog for .53/.54 [skip ci] v7.0.0-beta.54 also default stage 2 to decoratorsLegacy true [skip ci] Fix stage-0/1 import of pipeline/decorators proposals (babel#8317) Remove micromatch and use a simple pattern matching utility. Ensure that the wildcard interop is used with re-export + default. (babel#8316) Leave it to users to clear the require cache if they want to. Remove dependency on barely-used package. Add link to audio version of song (babel#8320) Remove option-filtering options from the final options results. (babel#8315) Update pirates to 4.0 (babel#8308) remove yearly preset folders [skip ci] v7.0.0-beta.53 Make env preset build-data scripts reproducible (babel#8299) TypeScript: Support type arguments on JSX opening and self-closing tags (babel#7799)
request
devDep, added devDep oncaniuse-db
, pinnedelectron-to-chromium
versionThe previous script had a few problems, which means builds are not reproducible:
This PR addresses these issues by:
caniuse-db
which is published to npm.electron-to-chromium
to the version used the last time the script was run.