Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make env preset build-data scripts reproducible #8299

Merged
merged 1 commit into from Jul 11, 2018

Conversation

@rtsao
Copy link
Contributor

rtsao commented Jul 10, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes, only internal change
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Removed request devDep, added devDep on caniuse-db, pinned electron-to-chromium version
License MIT

The previous script had a few problems, which means builds are not reproducible:

  1. It required internet access
  2. It fetched remote data without any versioning

This PR addresses these issues by:

  1. Using an explicit version of the caniuse-db which is published to npm.
  2. Pinning electron-to-chromium to the version used the last time the script was run.
@rtsao rtsao force-pushed the rtsao:update-env-data branch from 24b25b4 to d45addb Jul 10, 2018
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jul 10, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8576/

@rtsao rtsao force-pushed the rtsao:update-env-data branch from d45addb to c0f7b96 Jul 10, 2018
@@ -60,8 +60,8 @@
"@babel/core": "7.0.0-beta.52",
"@babel/helper-fixtures": "7.0.0-beta.52",
"@babel/helper-plugin-test-runner": "7.0.0-beta.52",
"caniuse-db": "1.0.30000851",

This comment has been minimized.

Copy link
@Andarist

Andarist Jul 10, 2018

Member

could we maybe try some auto-updates for caniuse-db & electron-to-chromium? maybe just a greenkeeper-like integration (as fully automatic probably would have numerous flaws)?

This comment has been minimized.

Copy link
@rtsao

rtsao Jul 10, 2018

Author Contributor

I've had good success with using https://renovatebot.com, which is very customizable and supports monorepos and is free for OSS.

This comment has been minimized.

Copy link
@hzoo

hzoo Jul 10, 2018

Member

Yeah we pinned the version of compat-table as well so this is good to me, unless we want to allow people to update before we do via peerDep or override if we are slow to update.

This comment has been minimized.

Copy link
@rtsao

rtsao Jul 10, 2018

Author Contributor

Although we'd need to get renovate to update dependencies and run the update script. I'm not sure if that'd be possible or not.

@hzoo
hzoo approved these changes Jul 10, 2018
@existentialism existentialism merged commit f2fd9e9 into babel:master Jul 11, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.39% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mAAdhaTTah added a commit to valtech-nyc/babel that referenced this pull request Jul 22, 2018
* master:
  remove .then from dynamic import parser exception message (babel#8355)
  update jest (major), babel-jest (major) (babel#8341)
  update prettier (babel#8339)
  bump flow (babel#8338)
  updates eslint, babel-eslint, eslint-plugin-flowtype, eslint-plugin-prettier (babel#8337)
  update changelog for .53/.54 [skip ci]
  v7.0.0-beta.54
  also default stage 2 to decoratorsLegacy true [skip ci]
  Fix stage-0/1 import of pipeline/decorators proposals (babel#8317)
  Remove micromatch and use a simple pattern matching utility.
  Ensure that the wildcard interop is used with re-export + default. (babel#8316)
  Leave it to users to clear the require cache if they want to.
  Remove dependency on barely-used package.
  Add link to audio version of song (babel#8320)
  Remove option-filtering options from the final options results. (babel#8315)
  Update pirates to 4.0 (babel#8308)
  remove yearly preset folders [skip ci]
  v7.0.0-beta.53
  Make env preset build-data scripts reproducible (babel#8299)
  TypeScript: Support type arguments on JSX opening and self-closing tags (babel#7799)
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.