Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option-filtering options from the final options results. #8315

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

loganfsmyth
Copy link
Member

Q                       A
Fixed Issues? Fixes babel/babel-loader#642
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Since these were getting left in, things that loaded the config, and then passed in back to Babel would get test and such twice, which could lead to either bad configuration merging, or no configuration at all if the patterns were relative to different directories, as was the case in babel/babel-loader#642.

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 13, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8597/

@loganfsmyth loganfsmyth merged commit fd9ebf9 into babel:master Jul 13, 2018
@loganfsmyth loganfsmyth deleted the remove-unexpected-options branch July 13, 2018 14:01
calebeby pushed a commit to Pigmice2733/scouting-frontend that referenced this pull request Jul 17, 2018
This Pull Request renovates the package group "babel monorepo".


-   [@​babel/preset-typescript](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/preset-env](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/plugin-transform-react-jsx](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/plugin-proposal-class-properties](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/core](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`

# Release Notes
<details>
<summary>babel/babel</summary>

### [`v7.0.0-beta.54`](https://github.com/babel/babel/releases/v7.0.0-beta.54)
[Compare Source](babel/babel@v7.0.0-beta.53...v7.0.0-beta.54)
#### v7.0.0-beta.54 (2018-07-16)

> Regarding `babel/babel#8184, we aren't using `micromatch` for paths, just basic `*/**` substitution now. For anything more complicated we will recommend using a regex/.js config.
> There was a bug in the stage presets (`babel/babel#8307), so we just removed the requirements for setting options in the meantime for ease of use. We are removing the Stage presets next anyway. `babel/babel#8293
##### 💥 Breaking Change
* `babel-core`, `babel-register`, `babel-traverse`
  * [#&#8203;8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@&#8203;loganfsmyth])
##### 🐛 Bug Fix
* `babel-core`, `babel-register`, `babel-traverse`
  * [#&#8203;8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@&#8203;loganfsmyth])
* `babel-preset-stage-0`, `babel-preset-stage-1`
  * [#&#8203;8317](`babel/babel#8317) Fix stage-0/1 import of pipeline proposals array. ([@&#8203;mAAdhaTTah])
* `babel-helper-module-transforms`, `babel-plugin-transform-modules-commonjs`
  * [#&#8203;8316](`babel/babel#8316) Ensure that the wildcard interop is used with re-export + default.. ([@&#8203;loganfsmyth])
* `babel-core`
  * [#&#8203;8315](`babel/babel#8315) Remove option-filtering options from the final options results.. ([@&#8203;loganfsmyth])
##### 📝 Documentation
* [#&#8203;8320](`babel/babel#8320) Add link to audio version of song. ([@&#8203;rugk])
##### Committers: 4
- Daniel Tschinder ([danez])
- James DiGioia ([mAAdhaTTah])
- Logan Smyth ([loganfsmyth])
- rugk ([rugk])

---


</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
mAAdhaTTah added a commit to valtech-nyc/babel that referenced this pull request Jul 22, 2018
* master:
  remove .then from dynamic import parser exception message (babel#8355)
  update jest (major), babel-jest (major) (babel#8341)
  update prettier (babel#8339)
  bump flow (babel#8338)
  updates eslint, babel-eslint, eslint-plugin-flowtype, eslint-plugin-prettier (babel#8337)
  update changelog for .53/.54 [skip ci]
  v7.0.0-beta.54
  also default stage 2 to decoratorsLegacy true [skip ci]
  Fix stage-0/1 import of pipeline/decorators proposals (babel#8317)
  Remove micromatch and use a simple pattern matching utility.
  Ensure that the wildcard interop is used with re-export + default. (babel#8316)
  Leave it to users to clear the require cache if they want to.
  Remove dependency on barely-used package.
  Add link to audio version of song (babel#8320)
  Remove option-filtering options from the final options results. (babel#8315)
  Update pirates to 4.0 (babel#8308)
  remove yearly preset folders [skip ci]
  v7.0.0-beta.53
  Make env preset build-data scripts reproducible (babel#8299)
  TypeScript: Support type arguments on JSX opening and self-closing tags (babel#7799)
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadPartialConfig fails to clear the overrides/test/include/exclude fields from its result
4 participants