Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to audio version of song #8320

Merged
merged 3 commits into from
Jul 13, 2018
Merged

Add link to audio version of song #8320

merged 3 commits into from
Jul 13, 2018

Conversation

rugk
Copy link
Contributor

@rugk rugk commented Jul 13, 2018

Q                       A
Fixed Issues? Fixes #8319
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? N/A
Documentation PR Link n
Any Dependency Changes? n
License MIT

existentialism
existentialism reviewed Jul 13, 2018
View reviewed changes
README.md Outdated
@@ -107,7 +107,7 @@ For questions and support please visit join our [Slack Community](https://slack.

### Is there a Babel song?

I'm so glad you asked: [Hallelujah —— In Praise of Babel](SONG.md) by [@angus-c](https://github.com/angus-c). Tweet us your recordings!
I'm so glad you asked: [Hallelujah —— In Praise of Babel](SONG.md) by [@angus-c](https://github.com/angus-c), [audio version](https://youtu.be/40abpedBKK8) by [Swyx](https://medium.com/@swyx). Tweet us your recordings!
Copy link
Member

@existentialism existentialism Jul 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to @sw-yx's twitter (https://twitter.com/@swyx) instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…or GitHub…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine too!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh hi haha. sure twitter is best

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 13, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8608/

@existentialism existentialism added the PR: Docs 📝 A type of pull request used for our changelog categories label Jul 13, 2018
@existentialism existentialism merged commit 62ee1ad into babel:master Jul 13, 2018
calebeby pushed a commit to Pigmice2733/scouting-frontend that referenced this pull request Jul 17, 2018
@renovate @calebeby
Update babel monorepo to v7.0.0-beta.54 (#235)
1b25e53 
This Pull Request renovates the package group "babel monorepo".


-   [@​babel/preset-typescript](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/preset-env](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/plugin-transform-react-jsx](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/plugin-proposal-class-properties](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/core](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`

# Release Notes
<details>
<summary>babel/babel</summary>

### [`v7.0.0-beta.54`](https://github.com/babel/babel/releases/v7.0.0-beta.54)
[Compare Source](babel/babel@v7.0.0-beta.53...v7.0.0-beta.54)
#### v7.0.0-beta.54 (2018-07-16)

> Regarding `babel/babel#8184, we aren't using `micromatch` for paths, just basic `*/**` substitution now. For anything more complicated we will recommend using a regex/.js config.
> There was a bug in the stage presets (`babel/babel#8307), so we just removed the requirements for setting options in the meantime for ease of use. We are removing the Stage presets next anyway. `babel/babel#8293
##### 💥 Breaking Change
* `babel-core`, `babel-register`, `babel-traverse`
  * [#&#8203;8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@&#8203;loganfsmyth])
##### 🐛 Bug Fix
* `babel-core`, `babel-register`, `babel-traverse`
  * [#&#8203;8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@&#8203;loganfsmyth])
* `babel-preset-stage-0`, `babel-preset-stage-1`
  * [#&#8203;8317](`babel/babel#8317) Fix stage-0/1 import of pipeline proposals array. ([@&#8203;mAAdhaTTah])
* `babel-helper-module-transforms`, `babel-plugin-transform-modules-commonjs`
  * [#&#8203;8316](`babel/babel#8316) Ensure that the wildcard interop is used with re-export + default.. ([@&#8203;loganfsmyth])
* `babel-core`
  * [#&#8203;8315](`babel/babel#8315) Remove option-filtering options from the final options results.. ([@&#8203;loganfsmyth])
##### 📝 Documentation
* [#&#8203;8320](`babel/babel#8320) Add link to audio version of song. ([@&#8203;rugk])
##### Committers: 4
- Daniel Tschinder ([danez])
- James DiGioia ([mAAdhaTTah])
- Logan Smyth ([loganfsmyth])
- rugk ([rugk])

---


</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
mAAdhaTTah added a commit to valtech-nyc/babel that referenced this pull request Jul 22, 2018
@mAAdhaTTah
Merge branch 'master' into implement-smart-pipeline-in-parser
baa971f 
* master:
  remove .then from dynamic import parser exception message (babel#8355)
  update jest (major), babel-jest (major) (babel#8341)
  update prettier (babel#8339)
  bump flow (babel#8338)
  updates eslint, babel-eslint, eslint-plugin-flowtype, eslint-plugin-prettier (babel#8337)
  update changelog for .53/.54 [skip ci]
  v7.0.0-beta.54
  also default stage 2 to decoratorsLegacy true [skip ci]
  Fix stage-0/1 import of pipeline/decorators proposals (babel#8317)
  Remove micromatch and use a simple pattern matching utility.
  Ensure that the wildcard interop is used with re-export + default. (babel#8316)
  Leave it to users to clear the require cache if they want to.
  Remove dependency on barely-used package.
  Add link to audio version of song (babel#8320)
  Remove option-filtering options from the final options results. (babel#8315)
  Update pirates to 4.0 (babel#8308)
  remove yearly preset folders [skip ci]
  v7.0.0-beta.53
  Make env preset build-data scripts reproducible (babel#8299)
  TypeScript: Support type arguments on JSX opening and self-closing tags (babel#7799)
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism left review comments

@swyxio swyxio swyxio left review comments

@xtuc xtuc xtuc approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to audio version of song
5 participants
@rugk @babel-bot @existentialism @xtuc @swyxio