Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .then from dynamic import parser exception message #8355

Merged
merged 1 commit into from
Jul 21, 2018

Conversation

dnalborczyk
Copy link
Contributor

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes?
License MIT

changes parser exception message for dynamic import. misleading/distracting from the fact that the parameter is required. .then is not required, and would also work with await, or even neither.

@dnalborczyk dnalborczyk changed the title remove .then from parser exception message remove .then from dynamic import parser exception message Jul 20, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 20, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8660/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nicolo-ribaudo nicolo-ribaudo merged commit 8b10a44 into babel:master Jul 21, 2018
@hzoo hzoo added the PR: Polish 💅 A type of pull request used for our changelog categories label Jul 21, 2018
mAAdhaTTah added a commit to valtech-nyc/babel that referenced this pull request Jul 22, 2018
* master:
  remove .then from dynamic import parser exception message (babel#8355)
  update jest (major), babel-jest (major) (babel#8341)
  update prettier (babel#8339)
  bump flow (babel#8338)
  updates eslint, babel-eslint, eslint-plugin-flowtype, eslint-plugin-prettier (babel#8337)
  update changelog for .53/.54 [skip ci]
  v7.0.0-beta.54
  also default stage 2 to decoratorsLegacy true [skip ci]
  Fix stage-0/1 import of pipeline/decorators proposals (babel#8317)
  Remove micromatch and use a simple pattern matching utility.
  Ensure that the wildcard interop is used with re-export + default. (babel#8316)
  Leave it to users to clear the require cache if they want to.
  Remove dependency on barely-used package.
  Add link to audio version of song (babel#8320)
  Remove option-filtering options from the final options results. (babel#8315)
  Update pirates to 4.0 (babel#8308)
  remove yearly preset folders [skip ci]
  v7.0.0-beta.53
  Make env preset build-data scripts reproducible (babel#8299)
  TypeScript: Support type arguments on JSX opening and self-closing tags (babel#7799)
storyn26383 pushed a commit to UniSharp/babel that referenced this pull request Aug 6, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants