Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for Flow's QualifiedTypeIdentifier #9396

Merged
merged 1 commit into from Jan 23, 2019
Merged

Conversation

@existentialism
Copy link
Member

existentialism commented Jan 23, 2019

Q                       A
Fixed Issues? Fixes #9393
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Y/Y
Documentation PR Link
Any Dependency Changes?
License MIT

Also added some sanity tests in generator.

@danez
danez approved these changes Jan 23, 2019
@existentialism existentialism merged commit d4e045a into master Jan 23, 2019
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.76% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@existentialism existentialism deleted the qualified-type-id branch Jan 23, 2019
@ilyalesik

This comment has been minimized.

Copy link
Contributor

ilyalesik commented Jan 29, 2019

Can you upload the new version (7.3.1) to npm? https://www.npmjs.com/package/@babel/types

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Jan 29, 2019

This PR has been merged after 7.3.1. it will be released in 7.3.2.

@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.