Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for Flow's QualifiedTypeIdentifier #9396

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Fix support for Flow's QualifiedTypeIdentifier #9396

merged 1 commit into from
Jan 23, 2019

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Jan 23, 2019 •
edited
Loading

Q                       A
Fixed Issues? Fixes #9393
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Y/Y
Documentation PR Link
Any Dependency Changes?
License MIT

Also added some sanity tests in generator.

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: types labels Jan 23, 2019
@existentialism existentialism merged commit d4e045a into master Jan 23, 2019
@existentialism existentialism deleted the qualified-type-id branch January 23, 2019 21:19
@ilyalesik
Copy link
Contributor

Can you upload the new version (7.3.1) to npm? https://www.npmjs.com/package/@babel/types

@nicolo-ribaudo
Copy link
Member

This PR has been merged after 7.3.1. it will be released in 7.3.2.

@existentialism existentialism mentioned this pull request Feb 25, 2019
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@danez danez danez approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flow] babel-types error when create declare class with QualifiedTypeIdentifier at InterfaceExtends
4 participants
@existentialism @ilyalesik @nicolo-ribaudo @danez