change var name for coherence #9579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10298/ |
|
It's either possible to rename this variable or use Just let me know what suits you ! |
|
Yes it is, but it is used as a boolean. Let me know then, if what I do next makes more sense then. |
nicolo-ribaudo
dismissed
their stale review
It doesn't work because, since it is a method, it needs to be called with the correct this context.
danez
reviewed
Feb 25, 2019
Co-Authored-By: tanohzana <tanohzana@gmail.com>
nicolo-ribaudo
approved these changes
Feb 26, 2019
xtuc
approved these changes
Feb 26, 2019
existentialism
added
PR: Polish 💅
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reding the code to understand how it worked, but I enciuntered this variable name called
printMethodand I thought it was going to be used afterwards, but it turned out it as only to test that the function existed, so I think it makes more sense to name it as a boolean.