persistent-cache + exportModuleMetadata are not compatible

[stefanpenner]

• make it work
• re-enable persist when exportModuleMetadata is enabled

cc @chadhietala (also note, exportModuleMetadata relies on private API _cache ...)

[chadhietala]

Why does this not work?

[rwjblue]

@chadhietala - It doesn't work because it relies on this.moduleMetadata which is only populated in processString, and when a given file is found in the cache it wouldn't have processString called on it (so its metadata would not have been added to the local cache).

The good news is that this is now pretty easy, using postProcess that was added to allow us to export more than just the resulting file.

See:

• Add postProcess method. broccolijs/broccoli-persistent-filter#50
• Print errors properly when cached. rwjblue/broccoli-jshint#42
• Print errors properly when cached. kellyselden/broccoli-jscs#82

[krisselden]

would it not be better to save the metadata the async cache?

[rwjblue]

@krisselden - Yes, that is what my suggestion is. 😺

[stefanpenner]

I think this is no longer a thing