Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mangle - Fix label shadowing #186

Closed
wants to merge 3 commits into from
Closed

Mangle - Fix label shadowing #186

wants to merge 3 commits into from

Conversation

boopathi
Copy link
Member

@boopathi boopathi commented Oct 13, 2016

Not sure if there are any other bugs that this will lead to. If so, afaik, it will only lead to LabelStatement bugs.

  • Adds a 250-300ms to mangler because of the double pass. Maybe we can add a flag to useLabels - maybe ? and when babel starts treating Labels in a separate namespace, we can remove the code - incase we merge this...
  • this needs traversing program twice because the second time, the vars get replaced from outer scope and we cannot bind the referencedIdentifier to its BindingIdentifier - as we check this based on the Identifier name

@kangax
Copy link
Member

kangax commented Oct 20, 2016

I submitted a proper fix so we'll try to get that in first — babel/babel#4758

@kangax kangax added this to the 0.0.7 milestone Oct 23, 2016
@boopathi
Copy link
Member Author

Boom !!!

@boopathi boopathi closed this Oct 27, 2016
@boopathi boopathi deleted the mangle-label-0 branch October 27, 2016 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants