Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mangling of Named Exports in Modules #518

Merged
merged 1 commit into from
May 5, 2017
Merged

Conversation

boopathi
Copy link
Member

@boopathi boopathi commented May 4, 2017

This completes one part of the problem where now Named exports are no
more mangled. But the other part, where we can convert

const foo = bar;
export {foo};

to

export const foo = bar;

is yet to be explored in DCE or other plugins.

+ Ref #479

This completes one part of the problem where now Named exports are no
more mangled. But the other part, where we can convert

```js
const foo = bar;
export {foo};
```

to

```js
export const foo = bar;
```

is yet to be explored in DCE or other plugins.
@codecov
Copy link

codecov bot commented May 4, 2017

Codecov Report

Merging #518 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   82.96%   83.11%   +0.14%     
==========================================
  Files          34       34              
  Lines        2524     2570      +46     
  Branches      897      922      +25     
==========================================
+ Hits         2094     2136      +42     
- Misses        257      258       +1     
- Partials      173      176       +3
Impacted Files Coverage Δ
...ages/babel-plugin-minify-mangle-names/src/index.js 77.64% <100%> (+1.1%) ⬆️
packages/babel-plugin-minify-simplify/src/index.js 80.9% <0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713fb8f...37878a5. Read the comment docs.

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label May 4, 2017
@boopathi boopathi added this to Mangler PRs in Mangler May 4, 2017
@boopathi boopathi merged commit 7f03281 into master May 5, 2017
@boopathi boopathi deleted the export-named-1 branch May 5, 2017 10:24
@boopathi boopathi moved this from Mangler PRs to Done in Mangler May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants