Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCE] Fix removal of ArrayPattern #622

Merged
merged 1 commit into from
Jul 8, 2017
Merged

[DCE] Fix removal of ArrayPattern #622

merged 1 commit into from
Jul 8, 2017

Conversation

boopathi
Copy link
Member

@boopathi boopathi commented Jul 8, 2017 •
edited
Loading

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Jul 8, 2017
@boopathi boopathi mentioned this pull request Jul 8, 2017
Closed
@boopathi boopathi merged commit 83f8819 into master Jul 8, 2017
@boopathi boopathi deleted the array-pattern-01 branch July 8, 2017 14:22
@boopathi boopathi mentioned this pull request Jul 8, 2017
Closed
ebdrup
ebdrup reviewed Mar 14, 2020
View reviewed changes
packages/babel-plugin-minify-dead-code-elimination/src/index.js
if (
binding.path.node.init &&
!scope.isPure(binding.path.node.init) &&
binding.path.parentPath.node.declarations
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently getting the error Cannot read property 'declarations' of null here. Doing steps to reproduce is a lot of work (big repo). So I thought I would take a wild stab in the dark and ask if you could see that it would in any way make sense to add a guard here for if binding.path.parentPath.node is null? If that doesn't make sense I apologise for wasting your time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebdrup ebdrup ebdrup left review comments

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees
No one assigned
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boopathi @ebdrup @vigneshshanmugam