Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow options for plugins disabled by default (babel-preset-minify) #823

Merged
merged 1 commit into from
May 1, 2018

Conversation

nemophrost
Copy link
Contributor

@nemophrost nemophrost commented Apr 24, 2018

Within babel-preset-minify, if you pass an options object for one of the plugins that is disabled by default (like removeConsole) it does not get enabled.

This PR fixes that, just ensuring any plugin you are setting options for is also enabled.

@nemophrost nemophrost changed the title Allow minify options for plugins disabled by default Allow options for plugins disabled by default (babel-preset-minify) Apr 24, 2018
Copy link
Member

@boopathi boopathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch!

@boopathi boopathi merged commit 7b17646 into babel:master May 1, 2018
@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants