fix: improve comments handling in presets + api + gulp #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vigneshshanmugam
commented
May 17, 2018
vigneshshanmugam
commented
- Minify Preset wont handle comments by default, instead pass through the options to babel generator
- Babel minify API will preserve default license comments.
- Fix Improve comments support #674
- Fix gulp-babel-minify "comments" option has weak default RegExp #668
- Fix License comments are removed #796
vigneshshanmugam
force-pushed
the
fix-comm
branch
from
88f4deb
to
5925633
Compare
j-f1
reviewed
May 17, 2018
| @@ -13,7 +13,7 @@ function gulpBabelMinify( | |||
| { | |||
| babel = babelCore, | |||
| minifyPreset = babelPresetMinify, | |||
| comments = /preserve|licen(s|c)e/, | |||
| comments = /^\**!|@preserve|@licen(c|s)e|@cc_on/, | |||
There was a problem hiding this comment.
Th (s|c) can be shortened to [sc].
There was a problem hiding this comment.
Cool, will update 👍
vigneshshanmugam
force-pushed
the
fix-comm
branch
from
8dce691
to
e4ff8a4
Compare
vigneshshanmugam
changed the title
This was referenced Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.