Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 #627

Merged
merged 27 commits into from
May 3, 2023
Merged

v2 #627

merged 27 commits into from
May 3, 2023

Conversation

cdubz
Copy link
Member

@cdubz cdubz commented Apr 15, 2023

TODO:

  • Fix datetime field issues for Safari
  • Override site settings form
  • Add site settings tests
  • Update localization strings

cdubz and others added 19 commits March 25, 2023 12:57
* Update Tempus Dominus to v6 (WIP)

* Re-add calendar input prepend container

* Normalize setting of default date values

* Migrate to Bootstrap 5 (WIP)

* Remove deprecated card columns implementation from dashboard

* Update BS5 data props

* Use Masonry layout for dashboard cards (for now)

This doesn't seem particularly ideal so may need a more involved refactor

* Update styles for Bootstrap 5 deprecations

* Remove resolutions crap

* Refactor deprecated BS4 classes

* Update list table styles

* Refactor deprecated jumbotron class usages

* Update close button structure

* Add `v2` branch to standard CI workflows
The two settings properties introduced here are not yet used.
@cdubz cdubz self-assigned this Apr 15, 2023
@github-actions
Copy link

Coverage Status

Coverage: 99.072% (+0.02%) from 99.055% when pulling 8211cb4 on v2 into 5b07631 on master.

@cdubz cdubz added the to review Triggers review app creation on PRs label Apr 15, 2023
@cdubz
Copy link
Member Author

cdubz commented Apr 15, 2023

Prefilled datetime fields are not recognized as valid in Safari on iOS and macOS —

image

On mobile Safari opening the datepicker and selecting changing the date or time is a workaround. On desktop Safari there appears to be no workaround.

Default values do work when tested in:

  • Firefox on Ubuntu
  • Firefox on macOS
  • Firefox on Windows
  • Chrome on Android
  • Chrome on macOS
  • Chrome on Windows
  • Edge on Windows

Example source

<input type="datetime-local" name="time" value="2023-04-15T06:44:31" class="form-control" required="" id="id_time">
<input type="hidden" name="initial-time" value="2023-04-15 06:44:31" id="initial-id_time">

@cdubz cdubz added to review Triggers review app creation on PRs and removed to review Triggers review app creation on PRs labels Apr 15, 2023
@cdubz cdubz added the to review Triggers review app creation on PRs label Apr 15, 2023
@cdubz cdubz removed the to review Triggers review app creation on PRs label May 3, 2023
@cdubz cdubz modified the milestone: 2.0.0 May 3, 2023
@cdubz cdubz merged commit 8545fb3 into master May 3, 2023
@cdubz cdubz deleted the v2 branch May 7, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant