hotfix: fixing marshaling of MsgWrappedCreateValidator
#393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
approved these changes
May 30, 2023
| @@ -417,7 +417,7 @@ func FuzzFinalizedChainInfo(f *testing.F) { | |||
| ) | |||
| numChains := datagen.RandomInt(r, 100) + 1 | |||
| for i := uint64(0); i < numChains; i++ { | |||
| czChainIDLen := datagen.RandomInt(r, 50) + 1 | |||
| czChainIDLen := datagen.RandomInt(r, 50) + 100 | |||
There was a problem hiding this comment.
This does not completely solve the issue as you can still have the same chain ID albeit with a lower probability. I suggest we create a hashmap or something to check for existing values and recreate the chainID until we get a unique one.
SebastianElvis
force-pushed
the
hotfix-create-val
branch
from
353b53a
to
9943d8c
Compare
SebastianElvis
changed the title
MsgWrappedCreateValidator and a flaky testMsgWrappedCreateValidator
SebastianElvis
force-pushed
the
hotfix-create-val
branch
from
8a7d2d3
to
9832a76
Compare
vitsalis
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes marshaling of MsgWrappedCreateValidator. The Pubkey inside MsgWrappedCreateValidator.MsgCreateValidator is in type Any, thus requires extra handling for marshaling/unmarshaling. Specifically, MsgWrappedCreateValidator needs to implement UnpackInterfacesMessage interface. This PR also adds a test ensuring the decoding is correct. This PR is largely based on #215 (files).