-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve guide #193
chore: improve guide #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, some minor comments
bbn-test-4/finality-providers/scripts/verify-new-fp-offchain.sh
Outdated
Show resolved
Hide resolved
bbn-test-4/finality-providers/scripts/verify-new-fp-offchain.sh
Outdated
Show resolved
Hide resolved
bbn-test-4/finality-providers/scripts/verify-new-fp-offchain.sh
Outdated
Show resolved
Hide resolved
exit 1 | ||
fi | ||
|
||
FP_CHANGED_FILES=$(fpChanged) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does the fpChanged
variable become set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a function we are calling loaded from . $CWD/fp-changed.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
networks/bbn-test-4/finality-providers/scripts/fp-changed.sh
Lines 7 to 8 in da77ed6
function fpChanged { |
Modifications for improvements on the guide
btc-pk
in command, use<staker_pk>
instead0.1sBTC
will be considered invalid registration0.[0-9]+