Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute Nodes broadcast NodeInfo with unknown approval status which overrides previous approvals/rejections #3783

Closed
frrist opened this issue Apr 11, 2024 · 0 comments · Fixed by #3785
Closed

Compute Nodes broadcast NodeInfo with unknown approval status which overrides previous approvals/rejections #3783

frrist opened this issue Apr 11, 2024 · 0 comments · Fixed by #3785
Assignees
@rossjones @frrist
Labels
type/bug Type: Something is not working as expected
Milestone
v1.3.1

Comments

@frrist
Copy link
Member

frrist commented Apr 11, 2024

Auto-approved/pending nodes receive unknown status since compute nodes broadcast empty approval state to requester node. There are several solutions to address this:

  • shoe-horn in a fix to the requester that ignores the status from compute nodes
  • remove the approval state and connected state from the NodeInfo structure as details are unknown to compute node. It's only relevant in the context of a requester node.
@frrist frrist added the type/bug Type: Something is not working as expected label Apr 11, 2024
This was referenced Apr 11, 2024
Closed
Closed
@frrist frrist added this to the Release v1.3.1 milestone Apr 11, 2024
frrist pushed a commit that referenced this issue Apr 11, 2024
fix: remove Liveness and Acceptance from NodeInfo
d3ecd52 
- fixes #3783
- Introduces NodeState type used to track NodeInfo, Liveness, and
  Acceptance. Removes the idea of Livenss and Acceptance from data sent
  by compute nodes to the Requester(s) since compute nodes should not
  influence their Liveness or Acceptance. Those are values related to
  the Requesters view of the network.
@frrist frrist mentioned this issue Apr 11, 2024
Merged
frrist pushed a commit that referenced this issue Apr 18, 2024
fix: remove Liveness and Acceptance from NodeInfo
0778a49 
- fixes #3783
- Introduces NodeState type used to track NodeInfo, Liveness, and
  Acceptance. Removes the idea of Livenss and Acceptance from data sent
  by compute nodes to the Requester(s) since compute nodes should not
  influence their Liveness or Acceptance. Those are values related to
  the Requesters view of the network.
frrist added a commit that referenced this issue Apr 18, 2024
@frrist
fix: remove Liveness and Acceptance from NodeInfo (#3785)
3b3d8a8 
- fixes #3783
- Introduces NodeState type used to track NodeInfo, Connection, and Membershio. Removes the idea of Connection and Membership from data sent by compute nodes to the Requester(s) since compute nodes should not
influence their Connection state or mmembership. Those are values related to the
Requesters view of the network.

---------

Co-authored-by: frrist <forrest@expanso.io>
aronchick pushed a commit that referenced this issue Apr 27, 2024
@frrist @aronchick
fix: remove Liveness and Acceptance from NodeInfo (#3785)
0852269 
- fixes #3783
- Introduces NodeState type used to track NodeInfo, Connection, and Membershio. Removes the idea of Connection and Membership from data sent by compute nodes to the Requester(s) since compute nodes should not
influence their Connection state or mmembership. Those are values related to the
Requesters view of the network.

---------

Co-authored-by: frrist <forrest@expanso.io>
@frrist frrist mentioned this issue May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossjones rossjones

@frrist frrist

Labels
type/bug Type: Something is not working as expected
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging a pull request may close this issue.

fix: remove Liveness and Acceptance from NodeInfo bacalhau-project/bacalhau
2 participants
@rossjones @frrist