Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Basic Bashtub tests #3669

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Add Basic Bashtub tests #3669

merged 3 commits into from
Mar 29, 2024

Conversation

js-ts
Copy link
Contributor

@js-ts js-ts commented Mar 21, 2024

Previously tests accidentally used demo network nodes if the node that
was started was a hybrid.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@js-ts js-ts changed the title Use local node in Bash tests when starting hybrid node. Add Basic Bashtub tests Mar 21, 2024
frrist
frrist reviewed Mar 21, 2024
View reviewed changes
pkg/storage/tracing/tracing.go Outdated
Dur("duration", dur).
Object("spec", &spec).
Dur("Duration", dur).
Str("Alias", spec.Alias).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checkedout code from this PR before it was merged #3667

frrist
frrist reviewed Mar 21, 2024
View reviewed changes
test/bin/bacalhau.sh Outdated
if test "$TYPE" = "requester"; then
if [[ "$TYPE" =~ "requester" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was already fixed via #3667. So you can rebase your changes on main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased

simonwo
simonwo reviewed Mar 26, 2024
View reviewed changes
test/list_nodes.sh Outdated

subject bacalhau node list --output json
assert_equal 0 $status
assert_match '1' $(echo $stdout | jq '. | length')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call to jq can just be jq length.

test/hello-world-docker-v2.sh Outdated
# Assuming create_node is a function that takes two arguments separated by space, not comma
create_node requester,compute

# source $BACALHAU_DIR/bacalhau.run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code

test/hello-world-docker-v2.sh Outdated
source bin/bacalhau.sh

testcase_can_run_docker_hello_world() {
# Assuming create_node is a function that takes two arguments separated by space, not comma
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a correct comment?

test/get-results.sh Outdated
assert_equal 0 $status
assert_match "15" $(echo $stdout)
assert_equal '' $stderr
rm -rf job-*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit naughty, if I have downloaded any job results separate to testing it will delete these also. Can't we work out the job folder from the job id?

@js-ts js-ts marked this pull request as ready for review March 29, 2024 06:38
aronchick
aronchick approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@aronchick aronchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@js-ts js-ts merged commit 3f1733a into main Mar 29, 2024
12 checks passed
@js-ts js-ts deleted the bashtub-tests branch March 29, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frrist frrist frrist left review comments

@simonwo simonwo simonwo approved these changes

@aronchick aronchick aronchick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@js-ts @aronchick @simonwo @frrist