Support MP deployments with self-generated TLS certificate #3721

frrist · 2024-03-27T23:52:55Z

Generates a TLS certificate for communication between clients and requester node.

coderabbitai · 2024-03-27T23:53:00Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aronchick

LGTM other than the password/defaults.

aronchick · 2024-03-28T16:30:50Z

ops/marketplace-tf/vars.tfvars

@@ -17,9 +17,9 @@ bacalhau_accept_networked_jobs = true

 bacalhau_otel_collector_endpoint = "http://analytics.bacalhau.tech:4318"

-bacalhau_requester_api_token = "token_for_requester_api"
-bacalhau_compute_api_token = "token_for_compute_api"
+bacalhau_requester_api_token = "password"


did you mean to check in these as defaults? Terraform offers a feature to generate a random string (or this should be left blank and required)

If these values are blank a random token will automatically be generated and used. I commit this since typing password was easier than the former when dev-ing.

I hate that we auto-generate tokens and ask the users to go through the logs or to a local file on desk to get whatever token was generated. We should either allow unsecure access by default, or fail if no token was provided. but we shouldn't auto generate tokens

I hate that we auto-generate tokens

As mentioned above, we only auto generate tokens if the users don't provide one as part of the deployment. Users are able to set the token to whatever value they'd like to use, and in the event they do so we will not auto-generate a token and use the one they've provided.

ask the users to go through the logs or to a local file on desk to get whatever token was generated

Tokens are returned via terraform outputs once the deployment completes. Users do not need to look in the logs for the tokens.

We should either allow unsecure access by default, or fail if no token was provided. but we shouldn't auto generate tokens

What's the motivation for this? I believe it's a some-what standard practice to generate a password (token) on the behalf of a user and instruct them to change it once they login, no?

i think i'm ok as well if we autogenerate (only if not provided) and the token goes into a defined file somewhere. Not logs. This feels like best practice to me.

rossjones · 2024-04-02T15:52:52Z

ops/marketplace-tf/modules/cloud-init/compute-cloud-init.yml

@@ -0,0 +1,107 @@
+# create the bacalhau user that will run the bacalhau process
+packages:
+  - vim


rossjones · 2024-04-02T15:57:48Z

ops/marketplace-tf/modules/cloud-init/compute-cloud-init.yml

+      ${bacalhau_service_file}
+
+  # bacalhau install-script to install a custom bacalhau version
+  - path: /etc/install-bacalhau.sh


/etc probably not the best place for this. /usr/local/sbin's the best place for binaries that need su,or /usr/local/bin if it is intended for wider use. If it's only used by the installer, then probably less of an issue.

rossjones · 2024-04-02T15:58:38Z

ops/marketplace-tf/modules/cloud-init/requester-cloud-init.yml

+      ${bacalhau_service_file}
+
+  # bacalhau install-script to install a custom bacalhau version
+  - path: /etc/install-bacalhau.sh


if you change the other one (not compulsory) then change this one too.

rossjones · 2024-04-02T16:01:18Z

ops/marketplace-tf/modules/gcp/compute_instances/compute/main.tf

@@ -74,7 +74,7 @@ locals {
  bacalhau_env_vars = {
    LOG_LEVEL                   = "debug"
    BACALHAU_NODE_LOGGINGMODE   = "default"
-    BACALHAU_DIR                = "/data"
+    BACALHAU_DIR                = "/bacalhau_repo"


This is okay, but wonder if it might be better in /opt/bacalhau/* eventually ?

c.f. https://refspecs.linuxfoundation.org/FHS_3.0/fhs/index.html

rossjones

LGTM. Couple suggestions for potential directory changes, but nothing urgent.

frrist requested review from aronchick, rossjones, simonwo and wdbaruni March 28, 2024 16:18

frrist mentioned this pull request Mar 28, 2024

Generate certificates requester three #3707

Merged

aronchick approved these changes Mar 28, 2024

View reviewed changes

frrist force-pushed the frrist/mp-tf/run-bacalhau-as-bacalhau-user branch from b464bbf to 93b3427 Compare April 2, 2024 15:11

Base automatically changed from frrist/mp-tf/run-bacalhau-as-bacalhau-user to main April 2, 2024 15:25

rossjones reviewed Apr 2, 2024

View reviewed changes

rossjones approved these changes Apr 2, 2024

View reviewed changes

frrist force-pushed the frrist/mp-tf/support-tls branch from 1033c70 to 4293be3 Compare April 10, 2024 20:40

frrist self-assigned this Apr 16, 2024

feat: deloy with TLS configured

ed997ea

frrist force-pushed the frrist/mp-tf/support-tls branch from 4293be3 to ed997ea Compare May 8, 2024 22:10

frrist enabled auto-merge (rebase) May 8, 2024 22:11

frrist merged commit 536f99d into main May 8, 2024
13 checks passed

frrist deleted the frrist/mp-tf/support-tls branch May 8, 2024 22:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support MP deployments with self-generated TLS certificate #3721

Support MP deployments with self-generated TLS certificate #3721

frrist commented Mar 27, 2024 •

edited

Loading

coderabbitai bot commented Mar 27, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

aronchick left a comment

aronchick Mar 28, 2024

frrist Mar 28, 2024 •

edited

Loading

wdbaruni Apr 16, 2024

frrist Apr 16, 2024

aronchick Apr 16, 2024 •

edited

Loading

rossjones Apr 2, 2024

rossjones Apr 2, 2024

rossjones Apr 2, 2024

rossjones Apr 2, 2024

rossjones left a comment

Support MP deployments with self-generated TLS certificate #3721

Support MP deployments with self-generated TLS certificate #3721

Conversation

frrist commented Mar 27, 2024 • edited Loading

coderabbitai bot commented Mar 27, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

aronchick left a comment

Choose a reason for hiding this comment

aronchick Mar 28, 2024

Choose a reason for hiding this comment

frrist Mar 28, 2024 • edited Loading

Choose a reason for hiding this comment

wdbaruni Apr 16, 2024

Choose a reason for hiding this comment

frrist Apr 16, 2024

Choose a reason for hiding this comment

aronchick Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

rossjones Apr 2, 2024

Choose a reason for hiding this comment

rossjones Apr 2, 2024

Choose a reason for hiding this comment

rossjones Apr 2, 2024

Choose a reason for hiding this comment

rossjones Apr 2, 2024

Choose a reason for hiding this comment

rossjones left a comment

Choose a reason for hiding this comment

frrist commented Mar 27, 2024 •

edited

Loading

coderabbitai bot commented Mar 27, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

frrist Mar 28, 2024 •

edited

Loading

aronchick Apr 16, 2024 •

edited

Loading