Make it easier to get in progress jobs of a certain type #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
aronchick
approved these changes
Apr 11, 2024
pkg/jobstore/boltdb/store_test.go
Outdated
| @@ -45,6 +45,7 @@ func (s *BoltJobstoreTestSuite) SetupTest() { | |||
|
|
|||
| jobFixtures := []struct { | |||
| id string | |||
| typ string | |||
There was a problem hiding this comment.
Stupid question - why not e the field "jobType" instead of "typ". Is this something idiomatic about go?
There was a problem hiding this comment.
type is a keyword, but I guess jobType should be okay.
Currently the inprogress index is just the ID of the job that is inprogress. This commit switches the inprogress index to a composite key containing both the ID and the Type of the job. This allows for filtering of active jobs of a certain type without having to serde each entire job referenced in the index. We may at a future date want to introduce CompositeIndex type alongside the current Index type.
rossjones
force-pushed
the
index-job-types
branch
from
75843d6
to
5497308
Compare
aronchick
pushed a commit
that referenced
this pull request
Apr 27, 2024
Currently the inprogress index is just the ID of the job that is inprogress. This PR switches the inprogress index to a composite key containing both the ID and the Type of the job. This allows for filtering of active jobs of a certain type without having to serde each entire job referenced in the index. We may at a future date want to introduce CompositeIndex type alongside the current Index type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the inprogress index is just the ID of the job that is inprogress. This PR switches the inprogress index to a composite key containing both the ID and the Type of the job. This allows for filtering of active jobs of a certain type without having to serde each entire job referenced in the index.
We may at a future date want to introduce CompositeIndex type alongside the current Index type.