Bump golang.org/x/net from 0.21.0 to 0.23.0 #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.21.0 to 0.23.0. - [Commits](golang/net@v0.21.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…for Dependabot PRs and auto-merge upon successful tests completion.
# Aider chat conversation:
USER: .github/*
ASSISTANT: To assist you with `.github/*` files, I need to know what specific changes you would like to make. Please provide the details of the changes you want to apply to the files within the `.github` directory. If you want to create or modify workflows, issue templates, or any other configuration, let me know the exact requirements.
USER: the dependabot isn't running when we get automated pulls. i think there's something wrong when in .github - how should i ch
ange the files in there so it works automatically? specifically, the tests should kick off (which happens via the '.circleci/
trigger_pipeline.sh' file, and then when done, if all the tests pass, it should auto merge.
ASSISTANT: To ensure that Dependabot pull requests trigger your CircleCI pipeline and subsequently auto-merge upon successful test completion, you'll need to make changes to your GitHub Actions workflow and potentially your repository settings.
First, you'll need a GitHub Actions workflow that triggers the CircleCI pipeline when a Dependabot PR is created or updated. Then, you'll need another workflow or job that listens for the successful completion of the CircleCI tests and merges the PR.
Here's a step-by-step guide on what changes to make:
1. Create a new GitHub Actions workflow file that triggers the CircleCI pipeline for Dependabot PRs.
2. Modify the existing CircleCI configuration to notify GitHub Actions when the tests pass.
3. Create or modify a GitHub Actions workflow to auto-merge the PR upon successful test completion.
Since I don't have the current contents of your `.github` directory, I'll provide you with a new workflow file that you can add to your `.github/workflows` directory. This file will be responsible for triggering the CircleCI pipeline and auto-merging the PR if the tests pass.
Here's the diff for creating a new GitHub Actions workflow file:
```diff
--- /dev/null
+++ .github/workflows/dependabot-auto-merge.yml
@@ -0,0 +1,31 @@
+name: Dependabot Auto Merge
+
+on:
+ pull_request:
+ types: [opened, synchronize, reopened]
+ branches:
+ - main
+ paths-ignore:
+ - '**.md'
+
+jobs:
+ trigger-circleci:
+ runs-on: ubuntu-latest
+ if: github.actor == 'dependabot[bot]'
+ steps:
+ - name: Trigger CircleCI Pipeline
+ run: .circleci/trigger_pipeline.sh
+ env:
+ BRANCH: ${{ github.head_ref }}
+ CIRCLE_TOKEN: ${{ secrets.CIRCLE_CI_TOKEN }}
+
+ check-circleci:
+ runs-on: ubuntu-latest
+ needs: trigger-circleci
+ steps:
+ - name: Wait for CircleCI tests
+ # You would need a script or action here that waits for the CircleCI tests to complete
+
+ auto-merge:
+ runs-on: ubuntu-latest
+ needs: check-circleci
+ steps:
+ - name: Auto merge PR
+ uses: actions/github-script@v3
+ with:
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+ script: |
+ const mergePayload = {
+ owner: context.repo.owner,
+ repo: context.repo.repo,
+ pull_number: context.payload.pull_request.number,
+ merge_method: 'squash'
+ };
+ github.pulls.merge(mergePayload);
```
Please note that you will need to fill in the `# You would need a script or action here that waits for the CircleCI tests to complete` part with an actual implementation that waits for the CircleCI tests to complete. This could be a custom script or a third-party action designed for this purpose.
Also, ensure that you have the `CIRCLE_CI_TOKEN` and `GITHUB_TOKEN` secrets set up in your repository's settings for this workflow to function correctly.
Remember to review and test these changes thoroughly before applying them to your main branch, as automated merges can have significant impacts on your codebase's stability.
aronchick
approved these changes
Apr 26, 2024
github-actions
bot
deleted the
dependabot/go_modules/golang.org/x/net-0.23.0
branch
aronchick
added a commit
that referenced
this pull request
Apr 27, 2024
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.21.0 to 0.23.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/c48da131589f122489348be5dfbcb6457640046f"><code>c48da13</code></a> http2: fix TestServerContinuationFlood flakes</li> <li><a href="https://github.com/golang/net/commit/762b58d1cf6e0779780decad89c6c1523386638d"><code>762b58d</code></a> http2: fix tipos in comment</li> <li><a href="https://github.com/golang/net/commit/ba872109ef2dc8f1da778651bd1fd3792d0e4587"><code>ba87210</code></a> http2: close connections when receiving too many headers</li> <li><a href="https://github.com/golang/net/commit/ebc8168ac8ac742194df729305175940790c55a2"><code>ebc8168</code></a> all: fix some typos</li> <li><a href="https://github.com/golang/net/commit/3678185f8a652e52864c44049a9ea96b7bcc066a"><code>3678185</code></a> http2: make TestCanonicalHeaderCacheGrowth faster</li> <li><a href="https://github.com/golang/net/commit/448c44f9287b6745f958d74aa2a17ec7761c2f13"><code>448c44f</code></a> http2: remove clientTester</li> <li><a href="https://github.com/golang/net/commit/c7877ac4213b2f859831366f5a35b353e0dc9f66"><code>c7877ac</code></a> http2: convert the remaining clientTester tests to testClientConn</li> <li><a href="https://github.com/golang/net/commit/d8870b0bf2f2426fc8d19a9332f652da5c25418f"><code>d8870b0</code></a> http2: use synthetic time in TestIdleConnTimeout</li> <li><a href="https://github.com/golang/net/commit/d73acffdc9493532acb85777105bb4a351eea702"><code>d73acff</code></a> http2: only set up deadline when Server.IdleTimeout is positive</li> <li><a href="https://github.com/golang/net/commit/89f602b7bbf237abe0467031a18b42fc742ced08"><code>89f602b</code></a> http2: validate client/outgoing trailers</li> <li>Additional commits viewable in <a href="https://github.com/golang/net/compare/v0.21.0...v0.23.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/bacalhau-project/bacalhau/network/alerts). </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Aronchick <aronchick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps golang.org/x/net from 0.21.0 to 0.23.0.
Commits
c48da13http2: fix TestServerContinuationFlood flakes762b58dhttp2: fix tipos in commentba87210http2: close connections when receiving too many headersebc8168all: fix some typos3678185http2: make TestCanonicalHeaderCacheGrowth faster448c44fhttp2: remove clientTesterc7877achttp2: convert the remaining clientTester tests to testClientConnd8870b0http2: use synthetic time in TestIdleConnTimeoutd73acffhttp2: only set up deadline when Server.IdleTimeout is positive89f602bhttp2: validate client/outgoing trailersDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.