Update channel loading logic in GUI

[dominikbach]

Fixes #609 .

Changes proposed in this pull request:

• new unified function for channel selection in matlabbatch: pspm_cfg_channel_selector
• implemented in the following GUI modules:

Single channel selection:

pspm_cfg_dcm
pspm_cfg_find_sounds
pspm_cfg_get_markerinfo
pspm_cfg_glm
pspm_cfg_pp_emg_data
pspm_cfg_pp_heart_data
pspm_cfg_pp_scr
pspm_cfg_sf
pspm_cfg_trim
pspm_cfg_resp_pp
pspm_cfg_split_sessions
pspm_cfg_sf
pspm_cfg_interpolate

Modality-agnostic channel selection

pspm_cfg_artefact_rm
pspm_cfg_extract_segments

Eyetracker channel selection

pspm_cfg_pupil_correct
pspm_cfg_pupil_preprocess
pspm_cfg_find_valid_fixations
pspm_cfg_gaze_convert
pspm_cfg_pupil_size_convert

multiple channels

pspm_cfg_combine_markerchannels

• removed unused functions pspm_downsample and associated GUI items

• removed unused option "simple SCR artefact removal" from pspm_cfg_artefact_rm

• removed superseded GUI item pspm_cfg_data_convert
  --

• fixed some bugs

[teddychao]

Questions that are mentioned on the PsPM meeting

• find_valid_fixations
  • Two options fields, eyes and newfile, are used by the GUI but not used by the function.
• glm
  • For sps, if we use sps to specify model.channel, pspm_glm will not report errors. This has been checked by the test function now. I am uncertain about the issue described at Bug in GUI for SPS GLM #607 about whether it comes from the GUI or the function.

[teddychao]

Corrections

1. src/ext/matlabbatch/cfg_util.m is converted into LF to make it in line with remaining functions.
2. src/pspm_cfg/pspm_cfg_artefact_rm.m variable names changed to be lowercases to make it in line with other functions.
3. In src/pspm/cfg/pspm_cfg_extract_segments.m, at line 187, timeunits should be timeunit.

[teddychao]

In this file and pspm_convert_ecg2hb, channel was set up as an independent variable, whilst in pspm_convert_ecg2hb_amri, channel is a field in options. It could be written intentionally in this way. I do not know if it is good to make these consistent.

[teddychao]

I add (PPG) here because "peripheral pulse oximetry" is not a very common name.

[teddychao]

I correct this file by adding scr_pp_options.channel. In pspm_scr_pp, channel is an independent variable from options.

[teddychao]

List of issues that I am unsure how to resolve

SF

The settings above leads to undefined mrk_chan in pspm_cfg_run_sf.

Extract segments

In the file pspm_cfg_run_extract_segments, at line 51--55, there is a switch loop where mode can be either auto or manual. mode is the first variable of pspm_extract_segments. However, in the function itself, the first variable is method. In the help text of pspm_extract_segments, method is not described In arguments, and I assume it is actually mode there. Yet, mode can be either file, data or model, so auto or manual is not included here. I do not know what is expected here.

[teddychao]

Hi @dominikbach Please have a look at: #666 (comment) and merge if you are happy with the current GUI test results. There are some issues #666 (comment)

[teddychao]

pspm_cfg_data_convert does not exist. Shall we create it or remove convert data from Tools? I am confused about why it is there.