Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pmod handling in pspm_glm #700

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Improve pmod handling in pspm_glm #700

merged 4 commits into from
Jun 3, 2024

Conversation

dominikbach
Copy link
Contributor

Fixes #191 and fixes #195 .

Changes proposed in this pull request:

  • initialise all pmods used in a multiple timing definition, i.e. if a pmod is defined for a condition which does not occur in session 1, then ensure that empty pmods with respective names are created in pspm_get_timing
  • write a test in pspm_glm to check that this is working

@dominikbach dominikbach self-assigned this Apr 26, 2024
@dominikbach dominikbach added the In Progress Currently being worked on label Apr 26, 2024
@dominikbach dominikbach added Completed & Waiting for Review Completed and waiting for review and removed In Progress Currently being worked on labels Jun 3, 2024
@dominikbach dominikbach merged commit e85a043 into develop Jun 3, 2024
1 check passed
@dominikbach dominikbach deleted the glm-pmod branch June 3, 2024 15:05
@teddychao teddychao removed the Completed & Waiting for Review Completed and waiting for review label Jun 24, 2024
@teddychao teddychao added this to the v7.0 milestone Aug 25, 2024
@teddychao teddychao mentioned this pull request Oct 8, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddychao teddychao teddychao approved these changes

Assignees

@dominikbach dominikbach

Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.

Initialise pmod structure in pspm_glm Parameter modulation only for several conditions, not all
2 participants
@dominikbach @teddychao