Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12: Provide full support for multisites. #37

Merged
6 commits merged into from Oct 24, 2019
Merged

Issue #12: Provide full support for multisites. #37

6 commits merged into from Oct 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2019

Fixes #12

@indigoxela
Copy link
Member

Nice work! But I do have one concern.

Currently b dl forces downloading to the main directory (modules, themes...) You now enforce downloading to the sites subdirs if it's a multisite install.

Both doesn't seem perfect to me.

If I use multisite, I always share at least the majority of contrib modules (hence main dir is fine). Only single modules and likely the theme or some layouts are site specific.
So your approach actually makes it more complicated for me to use "b" with multisite.

@ghost
Copy link
Author

ghost commented Oct 3, 2019

@indigoxela Thanks for the feedback! It's good to hear how other people use Backdrop/multisite.

So with this PR if you run b dl from within your site directory, it'll download to there (e.g. /sites/[SITE]/modules). Whereas if you run the same command from outside of a site directory (e.g. /backdrop), it'll download to there instead (e.g. /backdrop/modules). So basically it should download to wherever you run this from.

I believe this is how Drush for Drupal 7 works. Drush for Backdrop doesn't fully support multisites yet, which is why I started using b instead as it's much easier to fix 😃

How would you prefer it to work? E.g. where do you prefer to run commands from, and where do you want them to download to?

@ghost
Copy link
Author

ghost commented Oct 3, 2019

BTW @indigoxela, are you on Gitter? https://gitter.im/backdrop/backdrop-issues If so, we can chat there if it's easier.

@indigoxela
Copy link
Member

it should download to wherever you run this from.

Ah, I didn't test that from the backdrop root, as "b" says "BackdropCMS is not installed yet." - but downloads it then to the main dirs. Cool, very helpful!

The warning message was misleading me.

BTW: Drush with D7 allows downloading projects to anywhere, regardless of an install.

@ghost
Copy link
Author

ghost commented Oct 3, 2019

The warning message was misleading me.

Yeah, that message is displayed if b can't find a settings.php file and therefore there's technically no Backdrop site available. But in that case it can (and should IMO) still download things to the root directory. Maybe a separate issue can address the wording/display of that message...

b.php Outdated Show resolved Hide resolved
@ghost ghost merged commit 8e40c2f into backdrop-contrib:1.x-1.x Oct 24, 2019
@ghost ghost deleted the issue-12 branch October 24, 2019 12:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

b doesn't support multisite
1 participant