Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Submitted' info line height too high when text wraps #15

Closed
ghost opened this issue Dec 30, 2020 · 2 comments · Fixed by #16
Closed

'Submitted' info line height too high when text wraps #15

ghost opened this issue Dec 30, 2020 · 2 comments · Fixed by #16
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Dec 30, 2020

This issue was originally filed against the Forum repo since that's where the issue was noticed. However the code that causes the issue is in the Borg theme, hence this issue.

The submitted info for a forum post is vertically centred next to the author's image by setting the line-height to be the same height as the image. This works in most cases, except when the submitted info wraps to two lines. Then you get this:

We should work out a better way of vertically centring the submitted info so the line-height isn't affected...

@ghost
Copy link
Author

ghost commented Dec 30, 2020

Here's a PR: #16 It simply removes the CSS that sets the line-height and removes the padding. Removing this CSS doesn't seem to have any negative effects from my testing.

@ghost
Copy link
Author

ghost commented Dec 30, 2020

Here're before/after screenshots of:

  • No image
  • Image with short text
  • Image with long text

no_image

image_short

image_long

jenlampton added a commit that referenced this issue Jan 7, 2021
Issue #15: Remove unnecessary line-height for article 'submitted' info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants