Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken horizontal tab menus on smaller screens #67

Closed
izmeez opened this issue Sep 30, 2023 · 1 comment · Fixed by #121
Closed

Broken horizontal tab menus on smaller screens #67

izmeez opened this issue Sep 30, 2023 · 1 comment · Fixed by #121
Labels
bug Something isn't working needs testing Has a fix but needs testing

Comments

@izmeez
Copy link

izmeez commented Sep 30, 2023

I'm not sure if this is a deliberate design change or not. However, the Gin theme does not really have distinctive horizontal tab menus and on a small screen this appearance is lost and shows as options. This does not preserve the context as well as tabs do. Here are screen captures of small screens to illustrate.
The Seven theme with a small screen:
admin-seven-small-screen
The Gin theme with a small screen:
admin-gin-small-screen

@izmeez izmeez changed the title Broken horizntal tab menus on smaller screens Broken horizontal tab menus on smaller screens Sep 30, 2023
@laryn laryn added the bug Something isn't working label Mar 27, 2024
laryn added a commit to laryn/gin that referenced this issue Mar 27, 2024
@laryn
Copy link
Member

laryn commented Mar 27, 2024

@izmeez Are you able to test the linked PR? I'm departing somewhat from the Gin Drupal styles here (which actually may be more like Claro styles) and sticking to the responsive pattern Backdrop added to Seven, with the tabs hiding and expanding with the three dot pattern:

CleanShot.2024-03-27.at.17.28.30.mp4

@laryn laryn added the needs testing Has a fix but needs testing label Mar 27, 2024
@laryn laryn closed this as completed in #121 Apr 3, 2024
laryn added a commit that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs testing Has a fix but needs testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants