[UX] Update block modal button to say 'Update' instead of 'Save'

[jenlampton]

This occurred to me after submitting #2124...

The button on modals for configuring Blocks currently says Save block. That's likely going to cause people to think that after they click it they will be done, but in reality they also need to save the layout. If we updated the block button text it may be less misleading. How about 'Update block' for configuring an existing one?

(As a side note, adding blocks already says "Add block" instead of save, good job 👍 )

[quicksketch]

Not sure "Update" is a whole lot better than "Save", but it is a little better. Sounds good to me.

[jenlampton]

I think that you're right, a lot of people won't know the difference between the two meanings (or what Backdrop means when it uses them). But if we are at least consistent about "If you click Update then you also need to click another button" and "If you click Save then you are done doing whatever it was." It will become intuitive to people faster.

[Graham-72]

With PR backdrop/backdrop#1678 I have made the change from Save block to Update block and modified all the test files. On the most recent run the PHP53 tests passed but there was a failure in PHP7 tests that I do not understand, and I can do no more on the PR.

[klonos]

... but there was a failure in PHP7 tests that I do not understand

Not your fault @Graham-72... #2202 😉

[Graham-72]

@klonos thanks for your reassurance.

[klonos]

But if we are at least consistent about "If you click Update then you also need to click another button" and "If you click Save then you are done doing whatever it was." It will become intuitive to people faster.

That 👍 ...eventually I would like us to come up with a solution that communicates that "Not saved yet" message in a better way (that stays within the user viewport until either 'save' or 'cancel' are specifically pressed).

[quicksketch]

Thanks @Graham-72 for the PR! Sorry about that random failure, it's really been quite the headache.

I've merged backdrop/backdrop#1678 into 1.x and 1.5.x. Thanks!

[klonos]

Thanx @jenlampton for filing this, @Graham-72 for the PR and @quicksketch for merging. This is on par with what I plan to work on in #2441