Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout module revision in 10.0 is causing failure. #3130

Closed
Graham-72 opened this issue May 18, 2018 · 3 comments
Closed

Layout module revision in 10.0 is causing failure. #3130

Graham-72 opened this issue May 18, 2018 · 3 comments

Comments

@Graham-72
Copy link

I have a site that uses Views to generate pages using data from a specified node. One example is a page with path eventreport2/%. This is displayed by a layout specifically for this path. On the configure layout admin page the Context is set to 'Position 2:eventreport2/%' and the Type then automatically becomes 'string pass-through'.

Such pages with custom layouts are no longer being displayed after update to 10.0 and the log shows two reports
Notice: Undefined index: load callback in layout_get_layout_by_path() (line 1082 of layout.module)
and
Error: Function name must be a string in layout_get_layout_by_path() (line 1083 of layout.module)

I have fixed this temporarily by reverting to the previous version of layout.module, i.e. before Issue #3004.

Note: I am not using the Taxonomy module which was perhaps the reason for #3004.

@quicksketch
Copy link
Member

Fixing this is pretty simple, we should just check if a "load callback" is specified before attempting to call it. Right now it looks like it's NULL in @Graham-72's example. PR at backdrop/backdrop#2214 adds a simple check.

@quicksketch
Copy link
Member

quicksketch commented May 30, 2018

Additional test now added to ensure string pass-through arguments work as expected.

.

@quicksketch
Copy link
Member

Merged backdrop/backdrop#2214 into 1.x and 1.10.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants