-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX] Split path.path.inc file into their respective modules #3182
Comments
There is no reason node, taxonomy, and user can’t own their own hook implementations. They won’t be called unless path is enabled. This may be a hold over from when Path was a contrib module. Core doesn’t implement hooks for non-core modules. |
Indeed, It explains everything here. Thanks |
backdrop/backdrop#2254 is ready for review |
The PR looks good to me, but I would like someone with more knowledge on this to also take a look. By removing the path.path.inc file, we have lost this docblock:
Not sure if I get things right, but does the above mean that every |
This docblock is actually wrong I guess. And implementing a hook for a disabled module is no harm |
Looks great. I've merged backdrop/backdrop#2254 into 1.x. This shouldn't be an API change (it's functionally identical), but the rearrangement might surprise some people so I've not backported it into 1.10.x. |
https://github.com/backdrop/backdrop/blob/1.x/core/modules/path/path.path.inc
This file implements
hook_path_info
for 3 other core modules : node, taxonomy and user.Quoting the
path.path.inc
top comment:I really don't understand the point here. I think we are facing the same issue as #2952 (comment) with
hook_layout_context_info
.Some related issues : #2954 & #3024
--
PR backdrop/backdrop#2254
The text was updated successfully, but these errors were encountered: