Issue #3105: CoreUpdater sans swp file.

[serundeputy]

No description provided.

[backdrop-ci]

Related to: backdrop/backdrop-issues#3105

[backdrop-ci]

Website: http://2201.backdrop.backdrop.qa.backdropcms.org
Username: admin
Password: f9HZvwvE

[herbdool]

@serundeputy the patch https://patch-diff.githubusercontent.com/raw/backdrop/backdrop/pull/2201.patch still seems to have the swp binary in it.

[serundeputy]

thanks for looking @herbdool ; I'll try to look this weekend.

[serundeputy]

squashed to remove bad file from history

[herbdool]

@serundeputy I took a look at this in regards to Nate's comment about hiding this by default. Maybe you're working on it.

In update.theme.inc this might work to hide the link in admin/reports/updates:

foreach ($data as $project) {
    // Don't show a link to the "Update modules" page for core.
    $update_link = ($project['name'] != 'backdrop' || config_get('installer.settings', 'core_update'));

and add the "core_update" setting to installer.settings.json.

As for admin/modules/update may need to add back some of the logic in core/modules/installer/installer.manager.inc. Haven't taken a look yet.

[herbdool]

@serundeputy I took a stab at the rest. Here's my patch based on your latest patch. Want me to just roll a PR if you don't have the time?

issue3105-alt.patch.txt

[quicksketch]

@herbdool I would suggest just making a new PR. In an unfair GitHub restriction, @serundeputy can push to your PRs because he's a core committer, but non-committers can't collaborate on the same PR.

[quicksketch]

Replaced by #2289.

[backdrop-ci]

Website: http://2201.backdrop.backdrop.qa.backdropcms.org Removed