Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time saver plugin #22582

Closed
wants to merge 8 commits into from
Closed

Time saver plugin #22582

wants to merge 8 commits into from

Conversation

tduniec
Copy link
Contributor

@tduniec tduniec commented Jan 29, 2024

Hey, I just made a Pull Request!

Introducing timeSaver plugin. It does some analysis graphs and charts that helping your management and team how using scaffolder templates can bring value and savings to the onboarded Teams!!!

It is declarative so it requires to put some savings data for each template execution into the template definition. Checkout README

byTemplate
tsAllStats
tsAllStats2
tsByTeam
tsByTeam2

✔️ Checklist

  • ➖ A changeset describing the change and affected packages. (more info) // please let me know if this is needed on plugin init
  • ✔️ Added or updated documentation
  • ✔️ Tests for new functionality and regression tests for bug fixes
  • ✔️ Screenshots attached (for UI changes)
  • ✔️ All your commits have a Signed-off-by line in the message. (more info)

Please let me know if any changes are needed and what else should be accomplished moving forward publishing this plugin.

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
example-app packages/app none v0.2.92-next.0
example-backend packages/backend none v0.2.92-next.0
backstage-plugin-time-saver-backend plugins/time-saver-backend none v0.1.0
backstage-plugin-time-saver-common plugins/time-saver-common none v0.1.0
backstage-plugin-time-saver plugins/time-saver none v0.1.0

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@awanlin
Copy link
Collaborator

awanlin commented Jan 29, 2024

Hi @tduniec, this looks pretty awesome!

Just wanted to give you a heads up that there is currently a freeze on accepting new plugins while the Community repo is setup for them, more details here: #20266. You could host this on a public GitHub repo and publish it to NPM in the mean time? Then add it to the Plugin Directory by following the instructions here: https://backstage.io/docs/plugins/add-to-directory

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Uffizzi Cluster pr-22582 was deleted.

Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tduniec, not sure if you saw my comment - #22582 (comment) - worried you are putting in work that will be potentially lost.

@toma2395
Copy link

Hi @awanlin,

yes I have seen your comment.
So it means I should close the PR and keep it under my repo right ?
How then we can run all the pipelines to validate the code ?

@tduniec tduniec closed this Jan 29, 2024
@awanlin
Copy link
Collaborator

awanlin commented Jan 29, 2024

Yes, for the time being it would be best to close the PR and create this in a public repo. You would then have your own CI/CD pipeline that would handle validation etc.

The work to create a Community is just starting so I don't have any ETA yet on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants