Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to node 14 & 16 #6889

Merged
merged 5 commits into from
Sep 18, 2021
Merged

move to node 14 & 16 #6889

merged 5 commits into from
Sep 18, 2021

Conversation

Rugvip
Copy link
Member

@Rugvip Rugvip commented Aug 19, 2021

Time to phase out support for Node.js v12 and start making sure we're running smooth on v16. It is scheduled for active LTS at the end of October, while v12 is already in maintenance mode.

For now the primary version we use is still v14, but once this is merged we can start using v14+ features and syntax.

@Rugvip Rugvip requested a review from a team as a code owner August 19, 2021 13:06
@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 59f9d71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@backstage/create-app Patch
@backstage/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jhaals
jhaals approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@jhaals jhaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The future is here!

@Rugvip Rugvip mentioned this pull request Aug 19, 2021
Merged
@benjdlambert benjdlambert mentioned this pull request Aug 31, 2021
Closed
@benjdlambert
Copy link
Member

@backstage/maintainers I've fixed this up - should be ready to go now!

@benjdlambert
Copy link
Member

Hmm looks like 16 is throwing up some shiz with maybe running out of memory?

@benjdlambert
Copy link
Member

Looks like it's a problem with mock-fs not being supported in latest versions of 16, and it being a problem with the library as a whole after the door was shut. tschaub/mock-fs#332

Rugvip and others added 3 commits September 17, 2021 23:03
@Rugvip
move to node 14 & 16
d0a47c8 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
cli: switch out the jest yaml transform
050797c 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@benjdlambert @Rugvip
chore: fix prettier
bb6841b 
Signed-off-by: blam <ben@blam.sh>
@Rugvip Rugvip requested a review from a team as a code owner September 17, 2021 21:10
@Rugvip
packages,plugins: bump mock-fs to 5.1.0
2f9065d 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
git-release-manager: fix test
59f9d71 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
adamdmharvey
adamdmharvey approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@adamdmharvey adamdmharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I may suggest, a quick one to possibly sneak into this PR would be to remove the suggestion in the issue template for bug reporting of Node v12 as well:

https://github.com/backstage/backstage/blob/master/.github/ISSUE_TEMPLATE/bug_template.md
(right near the end)

Otherwise good technical debt cleanup !! 🧹

@Rugvip
Copy link
Member Author

Rugvip commented Sep 18, 2021

@adamdmharvey already part of it 😁 https://github.com/backstage/backstage/pull/6889/files#diff-48a6f3ad0aa7299a11cb515c6348781a5601ddf7c01e7165886b0bda36a50bebR41

@Rugvip Rugvip merged commit 59136a5 into master Sep 18, 2021
@Rugvip Rugvip deleted the rugvip/16 branch September 18, 2021 15:40
@fabiancook fabiancook mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdmharvey adamdmharvey adamdmharvey approved these changes

@OrkoHunter OrkoHunter OrkoHunter approved these changes

@benjdlambert benjdlambert benjdlambert approved these changes

@freben freben freben approved these changes

@jhaals jhaals jhaals approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rugvip @benjdlambert @jhaals @freben @OrkoHunter @adamdmharvey