fix: Add pod labels to pod spec inside deployment object #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
requested changes
Jun 5, 2023
There was a problem hiding this comment.
Hey @juissi-t ! Thank you for contributing this patch! 👍
The code looks good to me, however there's a few things to address:
- WDYT about extending this to include
commonAnnotationsas well? Do you think it would be useful? - You need to regenerate
README.md(update the version). It can be done by executingpre-commit run -aorhelm-docs --chart-search-root=charts --template-files=./_templates.gotmpl --template-files=README.md.gotmpl - In order to merge this PR we will need you to update your commit with Developer Certificate of Origin (can be done by
git commit -soption) and have it GPG signed
juissi-t
force-pushed
the
fix-110-commonlabels
branch
3 times, most recently
from
5025e37
to
c2cb47f
Compare
juissi-t
changed the title
juissi-t
force-pushed
the
fix-110-commonlabels
branch
from
c2cb47f
to
17e0c84
Compare
Frankly, I don't know if common annotations in pods would be useful. But since they are just annotations and already included in a lot of the other manifests, why not in the pod manifest as well? I added them to the pod spec now.
Done.
Done. |
juissi-t
force-pushed
the
fix-110-commonlabels
branch
from
17e0c84
to
7ef5951
Compare
vinzscam
reviewed
Jun 5, 2023
juissi-t
force-pushed
the
fix-110-commonlabels
branch
from
95f6a90
to
aaec036
Compare
vinzscam
requested changes
Jun 26, 2023
vinzscam
reviewed
Jun 26, 2023
juissi-t
force-pushed
the
fix-110-commonlabels
branch
from
aaec036
to
f8a611f
Compare
juissi-t
changed the title
juissi-t
force-pushed
the
fix-110-commonlabels
branch
2 times, most recently
from
2af478f
to
7fbdbf7
Compare
Signed-off-by: Juha Tiensyrjä <juha.tiensyrja@gmail.com>
juissi-t
force-pushed
the
fix-110-commonlabels
branch
from
7fbdbf7
to
ca69894
Compare
vinzscam
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add the labels defined in
podLabelsto pods managed by the deployment object.Existing or Associated Issue(s)
Fixes #110
Additional Information
n/a
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.