Skip to content

Commit c9a60fe

Browse files
authored
Merge pull request #221 from schultzp2020/reviewer-role
docs: add reviewer role
2 parents 0927bd8 + 416eb46 commit c9a60fe

File tree

1 file changed

+38
-0
lines changed

1 file changed

+38
-0
lines changed

GOVERNANCE.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ in the [Backstage GitHub organization](https://github.com/backstage).
99
- [Project Roles](#project-roles)
1010
- [Contributor](#contributor)
1111
- [Organization Member](#organization-member)
12+
- [Reviewer](#reviewer)
1213
- [Plugin Maintainer](#plugin-maintainer)
1314
- [Project Area Maintainer](#project-area-maintainer)
1415
- [Core Maintainer](#core-maintainer)
@@ -149,6 +150,43 @@ Open an issue towards
149150

150151
- Membership in the Backstage GitHub organization
151152

153+
### Reviewer
154+
155+
A Reviewer is a Contributor who has shown a commitment to the project by
156+
providing helpful and constructive feedback on pull requests. While anyone is
157+
encouraged to review pull requests, a Reviewer is formally recognized as a
158+
trusted voice in the review process. This role is a great way to contribute to
159+
the project and can be a stepping stone towards becoming a maintainer.
160+
161+
#### Responsibilities
162+
163+
- Actively review pull requests, providing constructive, kind, and helpful
164+
feedback.
165+
- Follow the project's
166+
[reviewing guide](https://github.com/backstage/backstage/blob/master/REVIEWING.md).
167+
- Help contributors get their PRs into a mergeable state.
168+
- Help triage issues and apply labels where appropriate.
169+
170+
#### Requirements
171+
172+
- Has a track record of providing high-quality, constructive reviews on several
173+
pull requests across the project.
174+
- Demonstrates a good understanding of the project's coding conventions, values,
175+
and best practices.
176+
- Is supportive of new and occasional contributors and helps get useful PRs in
177+
shape to merge.
178+
179+
#### Privileges
180+
181+
- May be formally requested for reviews on specific PRs.
182+
- May be granted triage access to repositories to help manage issues and PRs.
183+
184+
#### Becoming a Reviewer
185+
186+
Contributors can be nominated by any Project Area or Core Maintainer. The
187+
nomination is discussed and approved by the maintainers of the relevant project
188+
area(s).
189+
152190
### Plugin Maintainer
153191

154192
A Plugin Maintainer is responsible for maintaining an individual Backstage

0 commit comments

Comments
 (0)