Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtrace error.message does not reflect assert #49

Open
alecazam opened this issue Oct 25, 2023 · 2 comments
Open

Backtrace error.message does not reflect assert #49

alecazam opened this issue Oct 25, 2023 · 2 comments

Comments

@alecazam
Copy link

alecazam commented Oct 25, 2023

This is the error.message recorded from an abort. But the prior command to this abort was an assert with useful text. Can we override this? And why does this default string contain a formatting token?

error.message samples:
STATUS_FATAL_APP_EXIT: {Fatal Application Exit} %hs <- reported from stack below
EXCEPTION_ACCESS_VIOLATION_WRITE
EXCEPTION_ACCESS_VIOLATION_READ
EXCEPTION_BREAKPOINT

Is this mangled string supposed to be what we see in traces. Most crash reports skip some number of stack levels to report what is at 03.

[ 00 ] ??$FromPointerCast@_KPEAU_EXCEPTION_POINTERS@@@crashpad@@YA_KPEAU_EXCEPTION_POINTERS@@@Z
[ 01 ] raise(int) ( signal.cpp:547 )
[ 02 ] abort() ( abort.cpp:71 )
[ 03 ] VulkanRenderer::CreateTexture(char const *,TextureDescriptor const &) ( VulkanRenderer.cpp:5969 ) <- our code
@alecazam
Copy link
Author

For now, we'll just record file/line message of the assert in simple_annotations(). But I'd still like to know if we can override error.message so that becomes the bug title.

@alecazam
Copy link
Author

alecazam commented Nov 1, 2023

Seems like we can override error.message and have it reflect our "file:line: msg"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant