Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/topologyspreadcontraint #195

Merged
merged 5 commits into from
Jul 18, 2022
Merged

Feature/topologyspreadcontraint #195

merged 5 commits into from
Jul 18, 2022

Conversation

dschunack
Copy link
Contributor

Describe what this PR does

Add the possibility to use topologySpreadConstraints in the helm chart.

Is there anything that requires special attention?

NONE

Related issues:

#194

@JohnStrunk
Copy link
Member

@dschunack Thanks for the PR!
Looks like there's just a line length issue that the linter doesn't like, then it should be good to go.

./helm/snapscheduler/README.md:147: MD013 Line length

@dschunack
Copy link
Contributor Author

@JohnStrunk I added a new line to fix it :-)

@JohnStrunk
Copy link
Member

JohnStrunk commented Jul 15, 2022

DCO didn't like the missing sign-off...
If you pull the branch to get github's commit, then: git commit -s --amend --no-edit, it should add your sign-off, then you can git push --force

Contributions should be easier than this. 😢

@dschunack
Copy link
Contributor Author

@JohnStrunk i know, i used the resolve Button in the GitHub WebUI. I will fix this tomorrow

dschunack and others added 5 commits July 17, 2022 18:55
Signed-off-by: dschunack <dschunack@web.de>
Update README.md

Signed-off-by: dschunack <dschunack@web.de>
Signed-off-by: dschunack <dschunack@web.de>
Signed-off-by: dschunack <dschunack@web.de>
Co-authored-by: John Strunk <jstrunk@redhat.com>
Signed-off-by: dschunack <dschunack@web.de>
@dschunack
Copy link
Contributor Author

@JohnStrunk so, now with sign-off :-)

Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@mergify mergify bot merged commit 8a39d21 into backube:master Jul 18, 2022
@dschunack dschunack deleted the feature/topologyspreadcontraint branch July 18, 2022 14:17
@dschunack
Copy link
Contributor Author

@JohnStrunk Is it possible to release a new version. Without we can't use the new features.

helm search repo backube/snapscheduler
NAME                 	CHART VERSION	APP VERSION	DESCRIPTION                                       
backube/snapscheduler	3.0.0        	3.0.0      	An operator to take scheduled snapshots of Kube...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants