Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations for v5 #851

Closed
13 tasks done
tombruijn opened this issue Apr 22, 2017 · 11 comments
Closed
13 tasks done

Deprecations for v5 #851

tombruijn opened this issue Apr 22, 2017 · 11 comments
Assignees

Comments

@tombruijn
Copy link
Member

tombruijn commented Apr 22, 2017

We need to deprecate some stuff because it's too hard to maintain for us now.

Some suggestions below. Let us know if you agree/disagree or use any of these.

These features will still be present in older versions of backup, =< v5, but going forward Backup will support less features that are not actively used.

core features

Databases

Storages

Syncers

Notifiers

@tombruijn tombruijn added this to the Next version milestone Apr 22, 2017
tombruijn added a commit that referenced this issue Apr 23, 2017
This was referenced Apr 23, 2017
tombruijn added a commit that referenced this issue May 3, 2017
@masterT
Copy link

masterT commented May 4, 2017

I love the syncer feature, I use Rsync.

@tombruijn
Copy link
Member Author

@masterT thanks for the feedback! We're thinking of removing the syncing feature as it doesn't really provide good backups. It's just a mirror of the state of your backup model at a certain time. If a file is removed it's removed in your backup as well. It doesn't provide any versioning or a snapshot of something longer ago than the timeframe of your backup schedule.

@tombruijn tombruijn reopened this May 13, 2017
@tombruijn tombruijn removed this from the Next version milestone May 13, 2017
@zaolin
Copy link

zaolin commented May 26, 2017

AWS S3 does versioning for you. That's why the syncer feature works for S3 in combination with a database backup!

@dhampik
Copy link

dhampik commented Jun 10, 2017

@tombruijn why are you removing sudo option?
That's a security concern. I'm using it and sudo is configured for specific user to allow only /bin/tar command, so basically this user is really limited to what he can do.
Does it mean that I'll need to give a full root permissions to the user under which backup is performed?
Isn't it too much?

😞

@Xosmond
Copy link

Xosmond commented Aug 9, 2017

Why are you removing Twitter notifier? Is there a problem with the API?

@stuartellis
Copy link
Contributor

@Xosmond - Making Backup maintainable is a problem. The intention here was to reduce the burden by deprecating things that we don't use ourselves, and so cannot test.

This ticket has been made obsolete by the change in #879, which switches the project to maintenance only. Having said that, I know that we may have to close some issues as "won't fix" because we do not have the means to easily test fixes.

@tombruijn
Copy link
Member Author

I'm also thinking of undoing the commit adding the deprecation warnings.
It confuses people and I'm planning on actually removing the deprecated things anymore

@stuartellis
Copy link
Contributor

@tombruijn - Sounds good to me. One of first steps I have for #884 is to go through the documentation and mark up the bits as basically "supported" or "not really supported".

@tombruijn
Copy link
Member Author

Deprecations reverted in #886
Will be undone in the next release

@tombruijn
Copy link
Member Author

beta 2 released, upgrade if you still get deprecation messages

elthariel pushed a commit to elthariel/backup that referenced this issue Oct 12, 2018
@jmuheim
Copy link

jmuheim commented Mar 27, 2020

upgrade if you still get deprecation messages

For those wondering how to do that:

$ gem install backup --pre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants