Memory optimisation: don't store whole build array #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change: combine build and merge steps so whole array of ska_dict are not stored in memory. On 28 Listeria (3228084, 38Mb skf file)
before:
1 thread 11s, 2.3Gb
8 threads 5s, 3Gb
after:
1 thread 8s, 500Mb
2 threads (max) 6s, 890 Mb
Closes #17 (but more ideas there to further reduce memory if ever needed)