Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64-bit windows builds are broken since uncode version of windows api is called #11

Closed
andyp71 opened this issue Apr 20, 2020 · 3 comments

Comments

@andyp71
Copy link

andyp71 commented Apr 20, 2020

You'd better replace

OutputDebugString with OutputDebugStringA
RegisterEventSource with RegisterEventSourceA
ReportEvent with ReportEventA

You should call the "A" version of these functions explicitly, since you pass ansi char strings to them.
Otherwise 64-bit windows builds are broken. OutputDebugString is defined to OutputDebugStringW on 64-bit platform and compiler can not convert const char* to required LPCWSTR.

@badaix
Copy link
Owner

badaix commented Apr 21, 2020

Can you please check if the develop branch is working?
There happened some development in the Snapcast project which I've now merged into develop.
Regarding Windows: I can just take pull requests or fix trivial and obvious things, that can be fixed without having a Windows machine.

@andyp71
Copy link
Author

andyp71 commented Apr 21, 2020 via email

@badaix
Copy link
Owner

badaix commented Apr 21, 2020

Cool!

@badaix badaix closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants