This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Fixed snapcast etc/default files copy into package - supersedes PR #28/#26 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@badaix This is good to go and compiles successfully on OpenWRT 23.05 - Tested on x86 OpenWRT. Would you mind looking at this over the weekend - Won't take more than 6 min. |
|
Thanks! Sorry, for the delay. |
|
Thank you for taking the time to look at it :-) |
This was referenced Mar 29, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@badaix This PR aims to do all the work for you regarding restoring successful package compilation support on OpenWRT 23.05+ - you contribution is reviewing/merging this please :-)
This PR:
This PR supersedes #26
The instructions in #26 to successfully install the default snapserver/snapclient default config relied on a symlink trick.
On OpenWRT 23.05, the symlink did not resolve to the intended directory. As a result, the package building failed.
This PR supersedes #28
The instructions in #28 allowed one to produce a package without same config files.
This PR solves #23
No comment.