Wip typescript subscription with server #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
March 11, 2018 23:48
dylanaubrey
commented
Mar 18, 2018
| const scalarValueNode = valueNode as ScalarValueNode; | ||
| output = scalarValueNode.value; | ||
| } else if (valueNode.kind === "ObjectValue") { | ||
| const objectValueNode = valueNode as ObjectValueNode; |
There was a problem hiding this comment.
dylanaubrey
commented
Mar 18, 2018
|
|
||
| output = obj; | ||
| } else if (valueNode.kind === "ListValue") { | ||
| const listValueNode = valueNode as ListValueNode; |
There was a problem hiding this comment.
dylanaubrey
commented
Mar 18, 2018
| const type = schema.getType(name); | ||
|
|
||
| if (type instanceof GraphQLObjectType || type instanceof GraphQLInterfaceType) { | ||
| const objectOrInterfaceType = type as GraphQLObjectType | GraphQLInterfaceType; |
There was a problem hiding this comment.
dylanaubrey
commented
Mar 18, 2018
| export default function mergeObjects(obj: ObjectMap, src: ObjectMap, matcher: MergeObjectsMatcher): ObjectMap { | ||
| function mergeCustomizer(objValue: any, srcValue: any, key: string): any[] | undefined { | ||
| if (!isArray(objValue) || !isArray(srcValue)) return undefined; | ||
| const objValues = objValue as any[]; |
There was a problem hiding this comment.
dylanaubrey
commented
Mar 18, 2018
| function mergeCustomizer(objValue: any, srcValue: any, key: string): any[] | undefined { | ||
| if (!isArray(objValue) || !isArray(srcValue)) return undefined; | ||
| const objValues = objValue as any[]; | ||
| const srcValues = srcValue as any[]; |
There was a problem hiding this comment.
dylanaubrey
commented
Mar 18, 2018
| } | ||
|
|
||
| if (!(type instanceof GraphQLObjectType) && !(type instanceof GraphQLInterfaceType)) return undefined; | ||
| const objectOrInterfaceType = type as GraphQLObjectType | GraphQLInterfaceType; |
There was a problem hiding this comment.
dylanaubrey
commented
Mar 18, 2018
| try { | ||
| const context: RequestContext = { fieldTypeMap: new Map() }; | ||
| const updated = await this._requestParser.updateRequest(query, opts, context); | ||
| errors = validate(this._schema, updated.ast) as GraphQLError[]; |
There was a problem hiding this comment.
dylanaubrey
commented
Mar 18, 2018
| }; | ||
|
|
||
| if (cachePromise) output.cachePromise = cachePromise; | ||
| if (queryHash) output.queryHash = queryHash as string; |
There was a problem hiding this comment.
|
SonarQube analysis reported 8 issues
Watch the comments in this conversation to review them. |
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
===========================================
- Coverage 91.25% 79.24% -12.01%
===========================================
Files 5 39 +34
Lines 503 1349 +846
Branches 0 297 +297
===========================================
+ Hits 459 1069 +610
- Misses 44 207 +163
- Partials 0 73 +73
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.