last merge causes ImportError: No module named configobj

[tessus]

The last merge causes the following error (seen on MacOSX and Linux):

Traceback (most recent call last):
  File "gitcheck.py", line 18, in <module>
    from configobj import ConfigObj
ImportError: No module named configobj

[badele]

Ok, i will see, if i can replace the configobj by JSON object. i will see with the author's merged code

[tessus]

Thanks, configobj is not part of a standard python install, thus makes your script a bit incompatible.

[badele]

I have fixed temporary the problem. Sorry for the inconvenience.

[tessus]

thanks, this fixed the problem, but when I run your script, I see these useless messages:

Beginning scan... building list of git folders
Done

Can these be removed or put under a debug flag? Non-essential output on the terminal should only be displayed for debugging. Don't you think?

[badele]

Grrr i don"t understand the issue is closed (i think the comment ! :).

For you bug, i don"t understand, i have tested before commit and it's work
for me (Linux).

Can you send me more informations ?

BA

On Tue, Nov 25, 2014 at 7:44 PM, Helmut Tessarek notifications@github.com
wrote:

thanks, this fixed the problem, but when I run your script, I see these
useless messages:

Beginning scan... building list of git folders
Done

Can these be removed or put under a debug flag? Non-essential output on
the terminal should only be displayed for debugging. Don't you think?

—
Reply to this email directly or view it on GitHub
#12 (comment).

---

Bruno Adele
bruno.adele@jesuislibre.org
Perso: jesuislibre http://www.jesuislibre.org | blog
http://blog.jesuislibre.org | twitter http://twitter.com/jesuislibre |
flickr http://www.flickr.com/photos/b_adele
Pro: cendreo http://www.cendreo.com | blog http://blog.jesuislibre.org
Site : informemoi.com

[tessus]

No, no. Everything is fine. No worries. I was just talking about a cosmetic issue, not a functional problem.

I'll close this issue and open another one (later tonight), where I can explain it in more detail.

[badele]

Ok, now i understand your problem ! :) You do not have a problem :)

Since last merged code, you think the gitcheck is too verbose! Is that correct ?

[tessus]

Yes, that's correct. If I run it, I only want to see the result or the output shown with -v.
The output I pasted earlier seems more like a debug message. It has no information with regards to the git status, which is the main reason for your script.
I'm sure most people rather read important information than debug output. What's your opinion on that?

If you are ok with it, I can create a --debug option...

[badele]

Ok, no problem, i will add a --debug feature

[tessus]

Thank you.

Your script is really useful and I'm using it almost daily. Most of the time debug messages just distract you from the real information. I'm not saying debug info is not important (I'm using debug messages quite a lot), but it shouldn't be shown by default.

[ChristianTremblay]

In the pull request I just made (#13), I

1. Replaced configObj by a simple JSON file
2. removed the debug message (actually I just commented them using #DEBUG so we can re-use them later in a future -debug option).

I kept messages when sending email so the user know where the result file has been saved and that email is sent to whom...

[tessus]

Awesome. Your change to send emails is very useful. Especially, if you want to run it in the background on a server. The messages when sending emails are also very useful. I usually redirect the output to a file when I run the script in the background. Great change!