Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a rel='deletes' link #436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/middlewares/cache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,17 @@ export default function(client: Client): FetchMiddleware {
// If the response had a Link: rel=invalidate header, we want to
// expire those too.
if (response.headers.has('Link')) {
for (const httpLink of LinkHeader.parse(response.headers.get('Link')!).rel('invalidates')) {
const httpLinks = LinkHeader.parse(response.headers.get('Link')!);

for (const httpLink of httpLinks.rel('invalidates')) {
const uri = resolve(request.url, httpLink.uri);
stale.push(uri);
}

for (const httpLink of httpLinks.rel('deletes')) {
const uri = resolve(request.url, httpLink.uri);
deleted.push(uri);
}
}

// Location headers should also expire
Expand Down
74 changes: 74 additions & 0 deletions test/unit/middleware/cache.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/* eslint-disable no-console */
import { expect } from 'chai';

import { BaseState, Client, ForeverCache, Links, Resource } from '../../../src';

import cacheMiddleware from '../../../src/middlewares/cache';

const invoke = (response: Response, client: Client) => {
const mw = cacheMiddleware(client);

return mw(new Request('http://test.example', {
method: 'POST',
}), () => Promise.resolve(response));
};

describe('Cache middleware', () => {
const client = new Client('http://test.example');
client.cache = new ForeverCache();

const resource = new Resource(client, 'http://example/foo');
const resourceEvents: string[] = [];

beforeEach(() => {
const state = new BaseState({
client,
uri: 'http://example/foo',
data: 'hi',
headers: new Headers(),
links: new Links('http://example/foo')
});

client.cache.store(state);

client.resources.set('http://example/foo', resource);

resource.emit = event => {
resourceEvents.push(event);

return true;
};
});

it('Should normally not emit delete entries from cache', async () => {
await invoke(new Response(), client);

expect(client.cache.has('http://example/foo')).to.equal(true);
expect(resourceEvents).to.not.contain('delete');
});

it('Should normally not emit delete event when have rel="invalidates" link', async () => {
const response = new Response(null, {
headers: {
Link: '<http://example/foo>; rel="invalidates"',
}
});

await invoke(response, client);

expect(resourceEvents).to.not.contain('delete');
});

it('Should emit delete entries from cache when have rel="deletes" link', async () => {
const response = new Response(null, {
headers: {
Link: '<http://example/foo>; rel="deletes"',
}
});

await invoke(response, client);

expect(client.cache.has('http://example/foo')).to.equal(false);
expect(resourceEvents).to.contain('delete');
});
});