Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: no need to run lint on pull requests #453

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Conversation

amio
Copy link
Member

@amio amio commented Dec 13, 2020

It already runs on push

@vercel
Copy link

vercel bot commented Dec 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/badgen/badgennet/nfb1a1rqi
✅ Preview: In Progress

@amio amio merged commit e6d72e4 into master Dec 13, 2020
@wopian
Copy link
Contributor

wopian commented Dec 13, 2020

Push events don't happen on PRs from forked repos, so you won't get lint reporting from contributor PRs (unless that event has changed?)

The following runs as a push event on non-fork PRs and as a pull_request event on fork PRs

on:
  push:
  pull_request:
    branches:
    - '**:**'

@amio
Copy link
Member Author

amio commented Dec 14, 2020

@wopian Good point!

amio added a commit that referenced this pull request Dec 14, 2020
amio added a commit that referenced this pull request Dec 15, 2020
@amio amio deleted the lint-on-push-only branch May 24, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants