Badge request: GitHub last-commit variant based on "committer" timestamp

[pukkandan]

Are you experiencing an issue with...

• shields.io
• My own instance
• badge-maker NPM package

🪲 Description

Some commits can have a different "commit created" date and "committed date". This is especially seen when cherry-picking. In this case, the last commit badge shows the date of commit creation rather than the "committed date".

I don't know if this is intended behaviour - hence why I am opening this as a bug report. If this is indeed how it is expected to work, please consider this as a feature request to add a badge of the latter

🔗 https://img.shields.io/github/last-commit/yt-dlp/yt-dlp/master

Since the badge will change as soon as I push a new commit, I am also attaching a screenshot of how it looks like as of yt-dlp/yt-dlp@097b056

[pukkandan]

I'm sure I opened this as a bug report. No idea how it got tagged as question

[chris48s]

You're right that this badge looks at the "author" timestamp rather than the "committer" timestamp. It has been like that since the badge was added in 2017 so we wouldn't make that behaviour change to the existing badge now.
We could accept a PR for a second variant that shows the "committer" date instead if someone is interested in working on it.

shields/services/github/github-last-commit.service.js

Line 72 in cf7c9c1

return this.constructor.render({ commitDate: body[0].commit.author.date })