-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [GitHubLastCommit] by committer badge #8537
Add [GitHubLastCommit] by committer badge #8537
Conversation
|
}).required(), | ||
}).required() | ||
) | ||
.required() | ||
|
||
const queryParamSchema = Joi.object({ | ||
by_committer: Joi.equal(''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to #8543 (comment) I'd make this display_timestamp
with options author
and committer
defaulting to author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks. Updated
Hi @chris48s |
Thanks |
closes #6236
I added the
display_timestamp
queryParam, with optionsauthor
andcommitter
, defaulting toauthor
.I checked a couple of repos (for example https://api.github.com/repos/zero-to-mastery/start-here-guidelines/commits) but I couldn't find an example with a different date for
author
andcommitter
.http://localhost:8080/github/last-commit/google/skia/infra/config?display_timestamp=committer