-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow/validate bitbucket_username / bitbucket_password in private config schema #8472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a very mild case of paranoia because I feel like there was something we did intentionally once upon a time relative to Bitbucket cloud, but I can't find any supporting evidence and don't recall any specifics so I do not have a high level of confidence.
This seems like a simple and reasonable enough thing to do, so I'll chalk my paranoia up to a weird dream 🤷
I think its just oversight. The one thing I can think of where setting credentials for this could cause a problem would be if we weren't setting shields/services/bitbucket/bitbucket-pull-request.service.js Lines 66 to 73 in ae018cd
I think in general, the BitBucket badges are a bit of a patchwork: Not all of them work with both BB server and BB cloud. Not all of them support auth if you have credentials set. There's definitely some tidy up needed, but I don't think this causes any problem. |
closes #8445