-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use max_stable_version
in rust [crates] badge
#8687
Conversation
@chris48s +1. I had similar Qs on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@chris48s just wanted to check in on this? |
This is pending on me, and through a mixture of forgetfulness and not having adequate bandwidth, I haven't gotten round to it yet. Will try to soon though 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this is the route we want to go, apologies for this being held up waiting for action from my end!
Refs #8666
Refs #8667
This PR switches us to using
max_stable_version
if present, ormax_version
otherwise, as suggested in #8666While I was looking at this, I realised returning
json.version.num
makes no sense here and we should never take this branch. It is a hangover from a really really old implementationshields/server.js
Lines 459 to 528 in 302c860
/api/v1/crates/:crate
endpoint when we render this badge - never the/api/v1/crates/:crate/:version
endpoint, so we don't need to handle that response.