Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only try to close pool if one exists #8947

Merged
merged 2 commits into from Mar 4, 2023
Merged

only try to close pool if one exists #8947

merged 2 commits into from Mar 4, 2023

Conversation

chris48s
Copy link
Member

I was getting TypeError: Cannot read properties of undefined (reading 'end') running the service tests with a postgres_url set in my local.yml.

@chris48s chris48s added the developer-experience Dev tooling, test framework, and CI label Feb 26, 2023
@github-actions
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against cc812be

@repo-ranger repo-ranger bot merged commit 5651396 into badges:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris48s @calebcartwright