ensure color is string before calling toLowerCase() #10129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
bug
LitoMore
reviewed
May 4, 2024
| @@ -49,7 +49,7 @@ function normalizeColor(color) { | |||
| } else if (color in aliases) { | |||
| return aliases[color] | |||
| } else if (isHexColor(color)) { | |||
| return `#${color.toLowerCase()}` | |||
| return `#${color.toString().toLowerCase()}` | |||
There was a problem hiding this comment.
How about moving the toString() to isHexColor()? Like this below:
function isHexColor(s = '') {
return hexColorRegex.test(String(s))
}
The String(s) is safer here. Even if the value is null, it will not throw an error.
There was a problem hiding this comment.
I don't think that would really help tbh.
The issue here is that the current implementation of isHexColor() may already return true on a non-string input (I guess .test() implicitly casts to string), leading us to try and call toLowerCase() on an int. For example:
> isHexColor(111111)
true
so even if we make the cast explicit, we'd still need to call toString() in this block, or do it somewhere before we reach here.
Null or undefined already return false with the current implementation:
> isHexColor(null)
false
> isHexColor(undefined)
false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10128
I don't have a reliable repro for this bug, but somewhere along the line we are allowing a hex colour which is all numeric to not be a string.
I suggest hitting with a hammer until it plays nicely 🔨
(I'm aware that somewhere a typescript enthusiast is having an aneurysm)